Improve performance by avoiding unneeded promise wrapping #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Dec 30, 2017
jsor
previously approved these changes
Dec 30, 2017
| } | ||
|
|
||
| // did not return a promise? this is an error, convert into one for rejection below. | ||
| if (!$response instanceof PromiseInterface) { |
There was a problem hiding this comment.
This if should probably omitted and promise conversion should be completely delegated to resolve().
There was a problem hiding this comment.
I'm not opposed to your suggestion, but after trying this out locally, the performance improvement is much less significant. Do you feel this is more of a cosmetic issue or would this block these suggested changes?
jsor
approved these changes
Dec 30, 2017
This was referenced Dec 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This very simple PR avoids wrapping the return value from the request handler in another promise. The request handler will either return a promise or a value that can be consumed directly. When running example 99 with included benchmarking instructions, this simple change improves performance from ~2400 req/s to ~2500 req/s on my local machine.
Builds on top of #291