Documentation to recommend Server by default instead of advanced StreamingServer #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
force-pushed
the
server-streaming
branch
from
9b9ee57
to
b2cf2bc
Compare
jsor
reviewed
Dec 12, 2017
README.md
Outdated
| @@ -160,10 +200,11 @@ Check out [request](#request) for more details. | |||
|
|
|||
| ### Request | |||
|
|
|||
| An seen above, the `StreamingServer` class is responsible for handling incoming | |||
| connections and then processing each incoming HTTP request. | |||
| An seen above, the [`Server`](#server) and [`StreamingServer`](#streamingserver) | |||
README.md
Outdated
| been received (see also [`RequestBodyBufferMiddleware`](#requestbodybuffermiddleware) | ||
| for an alternative). | ||
| If you're using the advanced [`StreamingServer`](#streamingserver), the | ||
| request object will be procesed once the request headers have been received. |
clue
force-pushed
the
server-streaming
branch
from
b2cf2bc
to
2119dd5
Compare
|
@jsor Good catch, updated to fix minor typos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some documentation to recommend
Serverby default instead of the advancedStreamingServer. I've tried to keep changes to a minimum to ease review.There's still potential for a follow-up PR to eventually improve the README structure 👍
Builds on top of #266 and #271