Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests #270

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Refactoring tests #270

merged 1 commit into from
Dec 1, 2017

Conversation

carusogabriel
Copy link
Contributor

I've refactored some tests with assertNull method.

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some, my IDE did it. Gonna roll back 😅

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WyriHaximus WyriHaximus merged commit 08cf429 into reactphp:master Dec 1, 2017
@carusogabriel carusogabriel deleted the refatoring-tests branch December 1, 2017 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants