Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template params can only have one argument #212

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ See also the wiki for possible [cache implementations](https://github.com/reactp

### resolve()

The `resolve(string $domain): PromiseInterface<string,Exception>` method can be used to
The `resolve(string $domain): PromiseInterface<string>` method can be used to
resolve the given $domain name to a single IPv4 address (type `A` query).

```php
Expand Down Expand Up @@ -151,7 +151,7 @@ $promise->cancel();

### resolveAll()

The `resolveAll(string $host, int $type): PromiseInterface<array,Exception>` method can be used to
The `resolveAll(string $host, int $type): PromiseInterface<array>` method can be used to
resolve all record values for the given $domain name and query $type.

```php
Expand Down
2 changes: 1 addition & 1 deletion src/Query/ExecutorInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ interface ExecutorInterface
* ```
*
* @param Query $query
* @return \React\Promise\PromiseInterface<\React\Dns\Model\Message,\Exception>
* @return \React\Promise\PromiseInterface<\React\Dns\Model\Message>
* resolves with response message on success or rejects with an Exception on error
*/
public function query(Query $query);
Expand Down
4 changes: 2 additions & 2 deletions src/Resolver/ResolverInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ interface ResolverInterface
* ```
*
* @param string $domain
* @return \React\Promise\PromiseInterface<string,\Exception>
* @return \React\Promise\PromiseInterface<string>
* resolves with a single IP address on success or rejects with an Exception on error.
*/
public function resolve($domain);
Expand Down Expand Up @@ -87,7 +87,7 @@ public function resolve($domain);
* ```
*
* @param string $domain
* @return \React\Promise\PromiseInterface<array,\Exception>
* @return \React\Promise\PromiseInterface<array>
* Resolves with all record values on success or rejects with an Exception on error.
*/
public function resolveAll($domain, $type);
Expand Down