Ensure the buffer is not released twice #3448
Merged
+71
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When NettyOutbound#sendObject(java.lang.Object) is used, it is Netty's responsibility to release the buffer on success/error Fixes #3406
chemicL
approved these changes
Sep 30, 2024
| OutboundThen(NettyOutbound source, Publisher<Void> thenPublisher) { | ||
| this(source, thenPublisher, EMPTY_CLEANUP); | ||
| } | ||
|
|
||
| // This construction is used only with ChannelOperations#sendObject | ||
| // The implementation relies on Netty's promise that Channel#writeAndFlush will release the buffer on success/error |
There was a problem hiding this comment.
It would be worth to add another line comment that the release here happens only in case when we are sure that the processing doesn't delegate to Netty because of some failure before the exchange can be continued in the thenPublisher - which in a regular case takes ownership of the buffer.
|
@chemicL Thanks for the review! |
violetagg
added a commit
that referenced
this pull request
Sep 30, 2024
violetagg
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
NettyOutbound#sendObject(java.lang.Object)is used, it is Netty's responsibility to release the buffer on success/errorFixes #3406