Parse X-Forwarded-Prefix request header #3436
Merged
+183
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The X-Forwarded-Prefix can be obtained via `HttpServerRequest#forwardedPrefix()`. Resolves #3432
chemicL
commented
Sep 18, 2024
reactor-netty-http/src/main/java/reactor/netty/http/server/ConnectionInfo.java
Outdated
Show resolved
Hide resolved
chemicL
commented
Sep 18, 2024
reactor-netty-http/src/main/java/reactor/netty/http/server/ConnectionInfo.java
Show resolved
Hide resolved
violetagg
approved these changes
Sep 19, 2024
reactor-netty-http/src/main/java/reactor/netty/http/server/ConnectionInfo.java
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/server/ConnectionInfo.java
Outdated
Show resolved
Hide resolved
|
@violetagg I addressed the aspect of distinguishing missing header vs empty content and also added the handling of comma-separated components with removal of the trailing forward slashes in each component. |
violetagg
approved these changes
Sep 26, 2024
|
@violetagg as discussed, I updated the PR to include validation whether the header value starts with a slash. |
violetagg
requested changes
Oct 1, 2024
...or-netty-http/src/main/java/reactor/netty/http/server/DefaultHttpForwardedHeaderHandler.java
Outdated
Show resolved
Hide resolved
violetagg
approved these changes
Oct 1, 2024
chemicL
added a commit
that referenced
this pull request
Oct 1, 2024
violetagg
added a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The X-Forwarded-Prefix can be obtained via
HttpServerRequest#forwardedPrefix().