Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reactor · Oct 4, 2024 · 404536c · 404536c
1 parent da26883
commit 404536c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/reactor-netty-http/src/main/java/reactor/netty/http/HttpDecoderSpec.java b/reactor-netty-http/src/main/java/reactor/netty/http/HttpDecoderSpec.java
@@ -233,6 +233,7 @@ public int h2cMaxContentLength() {
 	 *
 	 * @param allowPartialChunks set to {@code false} to only allow sending whole chunks down the pipeline.
 	 * @return this option builder for further configuration
+	 * @since 1.1.23
 	 */
 	public T allowPartialChunks(boolean allowPartialChunks) {
 		this.allowPartialChunks = allowPartialChunks;

diff --git a/reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java b/reactor-netty-http/src/test/java/reactor/netty/http/client/HttpClientTest.java
@@ -1701,7 +1701,7 @@ void httpClientResponseConfigInjectAttributes() {
 		AtomicBoolean validate = new AtomicBoolean();
 		AtomicInteger chunkSize = new AtomicInteger();
 		AtomicBoolean allowDuplicateContentLengths = new AtomicBoolean();
-		AtomicBoolean allowPartialChunks = new AtomicBoolean();
+		AtomicBoolean allowPartialChunks = new AtomicBoolean(true);
 		disposableServer =
 				createServer()
 				          .handle((req, resp) -> req.receive()

diff --git a/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java b/reactor-netty-http/src/test/java/reactor/netty/http/server/HttpServerTests.java
@@ -975,7 +975,7 @@ void httpServerRequestConfigInjectAttributes() {
 		AtomicBoolean validate = new AtomicBoolean();
 		AtomicInteger chunkSize = new AtomicInteger();
 		AtomicBoolean allowDuplicateContentLengths = new AtomicBoolean();
-		AtomicBoolean allowPartialChunks = new AtomicBoolean();
+		AtomicBoolean allowPartialChunks = new AtomicBoolean(true);
 		disposableServer =
 				createServer()
 				          .httpRequestDecoder(opt -> opt.maxInitialLineLength(123)
@@ -995,6 +995,7 @@ void httpServerRequestConfigInjectAttributes() {
 				                      chunkSize.set((Integer) getValueReflection(decoder, "maxChunkSize", 2));
 				                      validate.set((Boolean) getValueReflection(decoder, "validateHeaders", 2));
 				                      allowDuplicateContentLengths.set((Boolean) getValueReflection(decoder, "allowDuplicateContentLengths", 2));
+				                      allowPartialChunks.set((Boolean) getValueReflection(decoder, "allowPartialChunks", 2));
 				                  })
 				          .bindNow();