Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Manipulating the DOM with Refs page #366

Merged
merged 2 commits into from
May 7, 2023
Merged

Translate Manipulating the DOM with Refs page #366

merged 2 commits into from
May 7, 2023

Conversation

andriawan
Copy link
Contributor

@andriawan andriawan commented Apr 28, 2023 •
edited
Loading

Closes #388

Description

This PR is aimed at resolving the task of translating the "Manipulating the DOM with Refs" page.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@andriawan andriawan force-pushed the translate-manipulating-the-dom-with-refs branch from ebd7c0c to a28e3d1 Compare April 28, 2023 03:05
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@andriawan andriawan force-pushed the translate-manipulating-the-dom-with-refs branch from a28e3d1 to 64d79dc Compare April 28, 2023 23:02
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@andriawan andriawan force-pushed the translate-manipulating-the-dom-with-refs branch from 64d79dc to b4d49ad Compare May 4, 2023 00:18
@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@r17x
Copy link
Collaborator

r17x commented May 4, 2023

Any updates @andriawan

@andriawan
Copy link
Contributor Author

Any updates @andriawan

Sorry for slow progress...kind of busy at main work... 😅
promise i will finish the translation this week @r17x

@andriawan andriawan force-pushed the translate-manipulating-the-dom-with-refs branch from b4d49ad to 3c2278e Compare May 5, 2023 14:39
@andriawan andriawan marked this pull request as ready for review May 5, 2023 14:43
@andriawan andriawan changed the title wip translate Manipulating the DOM with Refs Translate Manipulating the DOM with Refs page May 5, 2023
@andriawan
Copy link
Contributor Author

this PR is ready for review. cc @r17x @zainfathoni @mhaidarhanif @resir014 @mazipan

r17x
r17x requested changes May 6, 2023
View reviewed changes
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
src/content/learn/manipulating-the-dom-with-refs.md Outdated Show resolved Hide resolved
@andriawan andriawan force-pushed the translate-manipulating-the-dom-with-refs branch from 3c2278e to 49486b4 Compare May 6, 2023 07:22
@andriawan
Copy link
Contributor Author

been already improved translation node in the latest commit. cc @r17x

r17x
r17x approved these changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @andriawan 🚀

@r17x r17x force-pushed the translate-manipulating-the-dom-with-refs branch from 49486b4 to ae37c0c Compare May 7, 2023 20:25
@r17x r17x merged commit 69c16ef into reactjs:main May 7, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@andriawan @r17x
Translate Manipulating the DOM with Refs page (#366)
1ada86d
@andriawan andriawan deleted the translate-manipulating-the-dom-with-refs branch May 10, 2023 06:27
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@andriawan @FelixFern
Translate Manipulating the DOM with Refs page (reactjs#366)
08cc694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r17x r17x r17x approved these changes

@mhaidarhanif mhaidarhanif Awaiting requested review from mhaidarhanif

@resir014 resir014 Awaiting requested review from resir014

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

@mazipan mazipan Awaiting requested review from mazipan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manipulating the DOM with Refs
2 participants
@andriawan @r17x