Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Call fetches immediately - do not wait for idle #3146

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jul 13, 2024

Motivation

NetworkManager will fetch
immediately, rather than waiting for idle. With React 18+ it is expected for
React to better handle work with concurrent mode and batching. Due to this, it
is not longer deemed the best performance to wait for idle and instead we should
fetch immediately.

Solution

Call fetches immediately - do not wait for idle

IdlingNetworkManager is still available to keep the previous behavior.

Copy link

changeset-bot bot commented Jul 13, 2024

🦋 Changeset detected

Latest commit: 49ffec1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@data-client/react Minor
coinbase-lite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (226823a) to head (49ffec1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3146      +/-   ##
==========================================
- Coverage   98.79%   98.62%   -0.18%     
==========================================
  Files         131      131              
  Lines        2247     2248       +1     
  Branches      455      455              
==========================================
- Hits         2220     2217       -3     
- Misses         16       20       +4     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntucker ntucker merged commit 6325384 into master Jul 13, 2024
25 checks passed
@ntucker ntucker deleted the no-idle branch July 13, 2024 17:15
@github-actions github-actions bot mentioned this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant