-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Simplify action shapes #3143
Conversation
🦋 Changeset detectedLatest commit: 221fed5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 221fed5 | Previous: d225595 | Ratio |
---|---|---|---|
normalizeLong |
516 ops/sec (±0.23% ) |
508 ops/sec (±0.62% ) |
0.98 |
infer All |
9532 ops/sec (±0.37% ) |
9576 ops/sec (±1.56% ) |
1.00 |
denormalizeLong |
334 ops/sec (±2.56% ) |
328 ops/sec (±1.70% ) |
0.98 |
denormalizeLong donotcache |
886 ops/sec (±0.31% ) |
878 ops/sec (±2.04% ) |
0.99 |
denormalizeShort donotcache 500x |
1326 ops/sec (±0.06% ) |
1368 ops/sec (±0.16% ) |
1.03 |
denormalizeShort 500x |
959 ops/sec (±0.15% ) |
976 ops/sec (±0.10% ) |
1.02 |
denormalizeShort 500x withCache |
4898 ops/sec (±0.48% ) |
4846 ops/sec (±0.19% ) |
0.99 |
denormalizeLong with mixin Entity |
288 ops/sec (±0.34% ) |
303 ops/sec (±0.25% ) |
1.05 |
denormalizeLong withCache |
6588 ops/sec (±0.21% ) |
6434 ops/sec (±0.47% ) |
0.98 |
denormalizeLong All withCache |
6580 ops/sec (±0.20% ) |
6788 ops/sec (±0.19% ) |
1.03 |
denormalizeLong Query-sorted withCache |
6370 ops/sec (±0.24% ) |
6691 ops/sec (±0.52% ) |
1.05 |
denormalizeLongAndShort withEntityCacheOnly |
1459 ops/sec (±0.45% ) |
1473 ops/sec (±0.46% ) |
1.01 |
getResponse |
6354 ops/sec (±1.06% ) |
6013 ops/sec (±0.57% ) |
0.95 |
getResponse (null) |
5512467 ops/sec (±0.93% ) |
5589476 ops/sec (±1.02% ) |
1.01 |
getResponse (clear cache) |
293 ops/sec (±0.34% ) |
293 ops/sec (±0.40% ) |
1 |
getSmallResponse |
2580 ops/sec (±0.26% ) |
2736 ops/sec (±0.20% ) |
1.06 |
getSmallInferredResponse |
1987 ops/sec (±0.20% ) |
2024 ops/sec (±0.20% ) |
1.02 |
getResponse Query-sorted |
5664 ops/sec (±0.49% ) |
6641 ops/sec (±1.01% ) |
1.17 |
getResponse Collection |
5825 ops/sec (±0.60% ) |
6249 ops/sec (±1.05% ) |
1.07 |
get Collection |
5267 ops/sec (±1.73% ) |
5379 ops/sec (±1.32% ) |
1.02 |
setLong |
516 ops/sec (±0.18% ) |
511 ops/sec (±1.39% ) |
0.99 |
setLongWithMerge |
200 ops/sec (±0.29% ) |
202 ops/sec (±0.30% ) |
1.01 |
setLongWithSimpleMerge |
210 ops/sec (±0.44% ) |
207 ops/sec (±0.60% ) |
0.99 |
setSmallResponse 500x |
896 ops/sec (±0.18% ) |
894 ops/sec (±0.35% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
f36b186
to
636b8c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3143 +/- ##
==========================================
- Coverage 98.79% 98.79% -0.01%
==========================================
Files 126 128 +2
Lines 2248 2242 -6
Branches 460 455 -5
==========================================
- Hits 2221 2215 -6
Misses 16 16
Partials 11 11 ☔ View full report in Codecov by Sentry. |
c488ccc
to
8a9e2f7
Compare
Motivation
Solution
actions flattening
meta
for most actions (all but fetch) are just date information, to ensure common formatnormalize() interface
actions
namespaceAdd
actions
exportactions
is a namespace for all action creators. It is typicallypreferred to use Controller's type-safe dispatch methods, as
members of this namespace could have breaking changes in a minor release.
BREAKING CHANGE: Removed
createFetch
,createSet
,createSetResponse
from export. Use action.createFetch instead.