Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Get rid of fetch action.meta.nm #3139

Merged
merged 1 commit into from
Jul 8, 2024
Merged

enhance: Get rid of fetch action.meta.nm #3139

merged 1 commit into from
Jul 8, 2024

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jul 8, 2024

Motivation

Simplification

Solution

Get rid of fetch action.meta.nm. This is not used anywhere.

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: bc153ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@data-client/core Minor
@data-client/react Minor
example-benchmark Patch
coinbase-lite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: bc153ea Previous: ee509fb Ratio
normalizeLong 506 ops/sec (±0.45%) 510 ops/sec (±0.43%) 1.01
infer All 9529 ops/sec (±0.41%) 9523 ops/sec (±1.42%) 1.00
denormalizeLong 332 ops/sec (±1.10%) 325 ops/sec (±2.22%) 0.98
denormalizeLong donotcache 891 ops/sec (±0.62%) 897 ops/sec (±0.44%) 1.01
denormalizeShort donotcache 500x 1362 ops/sec (±0.16%) 1362 ops/sec (±0.22%) 1
denormalizeShort 500x 968 ops/sec (±0.33%) 987 ops/sec (±0.17%) 1.02
denormalizeShort 500x withCache 4972 ops/sec (±0.11%) 4941 ops/sec (±0.52%) 0.99
denormalizeLong with mixin Entity 299 ops/sec (±0.41%) 290 ops/sec (±0.52%) 0.97
denormalizeLong withCache 6827 ops/sec (±0.66%) 6221 ops/sec (±0.12%) 0.91
denormalizeLong All withCache 6559 ops/sec (±0.16%) 6794 ops/sec (±0.15%) 1.04
denormalizeLong Query-sorted withCache 6464 ops/sec (±0.45%) 6721 ops/sec (±0.33%) 1.04
denormalizeLongAndShort withEntityCacheOnly 1482 ops/sec (±1.22%) 1527 ops/sec (±0.55%) 1.03
getResponse 5898 ops/sec (±1.54%) 6117 ops/sec (±1.21%) 1.04
getResponse (null) 5388945 ops/sec (±0.39%) 5554386 ops/sec (±0.86%) 1.03
getResponse (clear cache) 294 ops/sec (±0.19%) 286 ops/sec (±0.91%) 0.97
getSmallResponse 2670 ops/sec (±0.22%) 2678 ops/sec (±0.15%) 1.00
getSmallInferredResponse 2055 ops/sec (±0.17%) 2079 ops/sec (±0.21%) 1.01
getResponse Query-sorted 5582 ops/sec (±0.17%) 6787 ops/sec (±0.37%) 1.22
getResponse Collection 6356 ops/sec (±0.80%) 6350 ops/sec (±1.16%) 1.00
get Collection 5532 ops/sec (±1.31%) 5668 ops/sec (±1.14%) 1.02
setLong 520 ops/sec (±0.30%) 512 ops/sec (±0.39%) 0.98
setLongWithMerge 198 ops/sec (±0.31%) 199 ops/sec (±0.41%) 1.01
setLongWithSimpleMerge 208 ops/sec (±0.54%) 210 ops/sec (±0.36%) 1.01
setSmallResponse 500x 888 ops/sec (±0.27%) 892 ops/sec (±0.11%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@ntucker ntucker merged commit 9df0f7c into master Jul 8, 2024
23 checks passed
@ntucker ntucker deleted the nm-meta branch July 8, 2024 14:25
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant