enhance: Remove throttle from fetch action #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 935fab9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 935fab9 | Previous: 2ad1811 | Ratio |
|---|---|---|---|
normalizeLong |
513 ops/sec (±0.39%) |
506 ops/sec (±0.61%) |
0.99 |
infer All |
9817 ops/sec (±0.60%) |
9677 ops/sec (±0.57%) |
0.99 |
denormalizeLong |
339 ops/sec (±1.40%) |
327 ops/sec (±2.76%) |
0.96 |
denormalizeLong donotcache |
908 ops/sec (±0.22%) |
896 ops/sec (±0.25%) |
0.99 |
denormalizeShort donotcache 500x |
1351 ops/sec (±0.16%) |
1367 ops/sec (±0.21%) |
1.01 |
denormalizeShort 500x |
968 ops/sec (±0.92%) |
969 ops/sec (±0.32%) |
1.00 |
denormalizeShort 500x withCache |
5061 ops/sec (±0.38%) |
4885 ops/sec (±0.53%) |
0.97 |
denormalizeLong with mixin Entity |
298 ops/sec (±0.45%) |
289 ops/sec (±0.64%) |
0.97 |
denormalizeLong withCache |
6561 ops/sec (±0.11%) |
6241 ops/sec (±0.21%) |
0.95 |
denormalizeLong All withCache |
6985 ops/sec (±0.15%) |
6614 ops/sec (±0.16%) |
0.95 |
denormalizeLong Query-sorted withCache |
6736 ops/sec (±0.65%) |
6317 ops/sec (±0.51%) |
0.94 |
denormalizeLongAndShort withEntityCacheOnly |
1504 ops/sec (±0.88%) |
1514 ops/sec (±1.32%) |
1.01 |
getResponse |
5938 ops/sec (±1.48%) |
5788 ops/sec (±1.73%) |
0.97 |
getResponse (null) |
5526242 ops/sec (±0.45%) |
5167211 ops/sec (±0.51%) |
0.94 |
getResponse (clear cache) |
290 ops/sec (±0.48%) |
290 ops/sec (±0.37%) |
1 |
getSmallResponse |
2690 ops/sec (±0.29%) |
2712 ops/sec (±0.33%) |
1.01 |
getSmallInferredResponse |
2055 ops/sec (±0.12%) |
2028 ops/sec (±0.22%) |
0.99 |
getResponse Query-sorted |
5539 ops/sec (±0.56%) |
5586 ops/sec (±0.34%) |
1.01 |
getResponse Collection |
6462 ops/sec (±1.10%) |
6418 ops/sec (±1.19%) |
0.99 |
get Collection |
5801 ops/sec (±0.98%) |
5790 ops/sec (±1.06%) |
1.00 |
setLong |
515 ops/sec (±0.37%) |
513 ops/sec (±0.30%) |
1.00 |
setLongWithMerge |
204 ops/sec (±0.32%) |
202 ops/sec (±0.20%) |
0.99 |
setLongWithSimpleMerge |
212 ops/sec (±0.37%) |
213 ops/sec (±0.44%) |
1.00 |
setSmallResponse 500x |
901 ops/sec (±0.22%) |
886 ops/sec (±1.80%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Simpler actions; less code
Solution
Remove throttle from FETCH_TYPE action
BREAKING CHANGE: action.meta.throttle -> !action.endpoint.sideEffect