Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc improvements #984

Merged
merged 3 commits into from
May 24, 2023
Merged

doc improvements #984

merged 3 commits into from
May 24, 2023

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented May 23, 2023 •
edited
Loading

Issues

Closes: #982

Summary

  • Updates usage of key from a kwarg to an attribute.
  • We also don't do a great job of explaining the available HTML attributes, as well as key differences (e.g. class vs class_name). This adds docs which cover that.
  • Updates links to custom js component template repo

Checklist

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.

@rmorshea rmorshea changed the title Better html docs doc improvements May 23, 2023
@rmorshea rmorshea marked this pull request as ready for review May 24, 2023 02:42
@rmorshea rmorshea merged commit c86c59d into reactive-python:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Docs on Keys
1 participant
@rmorshea