Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added warning for html.script #970

Merged
merged 7 commits into from
Apr 23, 2023
Merged

Conversation

ZEUS-03
Copy link
Contributor

@ZEUS-03 ZEUS-03 commented Apr 18, 2023

closes: #924

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@ZEUS-03 ZEUS-03 marked this pull request as ready for review April 18, 2023 15:26
src/reactpy/html.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@rmorshea rmorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved under the "Scripting" section and added to the docstring for script.

@ZEUS-03
Copy link
Contributor Author

ZEUS-03 commented Apr 19, 2023

@rmorshea does this fulfils the requirement?

src/reactpy/html.py Outdated Show resolved Hide resolved
@rmorshea rmorshea merged commit 0f34eb8 into reactive-python:main Apr 23, 2023
@ZEUS-03 ZEUS-03 deleted the fix-issue#924 branch April 24, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning for html.script
3 participants