Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sdist #1191

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

fix sdist #1191

wants to merge 17 commits into from

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Feb 4, 2024

By submitting this pull request you agree that all contributions to this project are made under the MIT license.

Issues

Closes: #1180
Closes: #1183

Solution

Create a link to the JS directory inside src/py/reactpy and include the JS dir as an sdist-only artifact

Checklist

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.

@rmorshea
Copy link
Collaborator Author

rmorshea commented Feb 11, 2024

@Archmonger I'm having some trouble with this on Windows, do you think you can try this branch out and see what's happening. In the meantime I'm gonna purchase a Windows license and install it on an old laptop so I can test this stuff myself going forward.

Never mind. Got past the windows issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotADirectoryError when installing from source distribution
1 participant