Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error message if no backend installed #1042 #1045

Merged
merged 8 commits into from
Jun 13, 2023

Conversation

geckguy
Copy link
Contributor

@geckguy geckguy commented Jun 12, 2023

Issues

closes: #1042

Summary

  • Added a better error message stating that no backend is installed
  • Suggested list of supported backends (imported from reactpy.backend.utils)

@geckguy
Copy link
Contributor Author

geckguy commented Jun 12, 2023

I have made the suggested changes, please do review

Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
@rmorshea
Copy link
Collaborator

It looks like there's some other linting issue. If you don't have a dev environment set up you can use this website to help format your code: https://play.ruff.rs/

@geckguy
Copy link
Contributor Author

geckguy commented Jun 12, 2023

It looks like there's some other linting issue. If you don't have a dev environment set up you can use this website to help format your code: https://play.ruff.rs/

I was working in VScode with all the req dependencies installed

@rmorshea
Copy link
Collaborator

rmorshea commented Jun 12, 2023

If you have a dev env setup you should be able to run hatch run lint-py --fix. It won't necessarily be able to fix everything though - to do a full check so you can resolve the other issue manually run hatch run lint-py

@geckguy
Copy link
Contributor Author

geckguy commented Jun 12, 2023

If you have a dev env setup you should be able to run hatch run lint-py --fix. It won't necessarily be able to fix everything though - to do a full check so you can resolve the other issue manually run hatch run lint-py

Fixed it. Should be good now

geckguy and others added 2 commits June 13, 2023 02:26
Co-authored-by: Ryan Morshead <ryan.morshead@gmail.com>
@geckguy
Copy link
Contributor Author

geckguy commented Jun 13, 2023

why are some checks still failing?

@rmorshea rmorshea merged commit 8120ddc into reactive-python:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Error Message If No Backend Installed
3 participants