-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pre-commit hook #1024
Added pre-commit hook #1024
Conversation
A couple areas for improvement:
|
@rmorshea Opinion on respective point
Planning to execute pre-commit in following order
|
We should make it so you don't have to run "fix" and then "check". The "fix" command should return a non-zero exit code if it needs to make corrections. For example, Ruff has a flag for this ( |
@rmorshea Actually I tried using
pre-commit will keep failing unless 4 of the steps completed successfully. What's your suggestion should we make pre-commit like above example (without hatch) or use hatch? |
I'll take a closer look at this shortly. |
I think we can proceed using |
@rmorshea We still need to enable precommit on the repo |
Issues
Resolve #925
Summary
Added back Pre-Commit Hook
Checklist
changelog.rst
has been updated with any significant changes.