Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1007

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Fix typos #1007

merged 4 commits into from
Jun 6, 2023

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Jun 6, 2023

Issues

Summary

Fix typos found via:

  • codespell -S package-lock.json -L inflight,ue,falsy
  • typos --format brief

Checklist

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.

Found via:
- `codespell -S package-lock.json -L inflight,ue,falsy`
- `typos --format brief`
Copy link
Collaborator

@rmorshea rmorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that worked remarkably well. Thanks!

Do you know if there's a VSCode extension that uses these same tools? I've tried this in the past but it just complains way too much. Perhaps there's a way to configure it properly and I've just been too lazy to do it though.

src/py/reactpy/tests/test_core/test_component.py Outdated Show resolved Hide resolved
src/py/reactpy/tests/test_core/test_component.py Outdated Show resolved Hide resolved
src/py/reactpy/tests/test_core/test_events.py Outdated Show resolved Hide resolved
@rmorshea rmorshea merged commit 4f98dcf into reactive-python:main Jun 6, 2023
17 checks passed
@Archmonger
Copy link
Contributor

@rmorshea I already have codespell as a plugin for mkdocs in reactpy-django (using mkdocs-spellcheck).

I will be porting the same thing to reactpy.

@kianmeng
Copy link
Contributor Author

kianmeng commented Jun 8, 2023

Do you know if there's a VSCode extension that uses these same tools? I've tried this in the past but it just complains way too much. Perhaps there's a way to configure it properly and I've just been too lazy to do it though.

Maybe through CI?

@kianmeng
Copy link
Contributor Author

kianmeng commented Jun 8, 2023

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants