Play nice with 0.29.2 on both platforms again. #406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hear this is the wrong way to do this. I'm not sure what the right way is. All I know is, without this change, the project doesn't compile on Android and RN 0.29.2. Feels wrong to specify the React Native version number in here, when at the NPM level, we target the "latest" React Native dependency with a *.
| @@ -16,7 +16,7 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile 'com.facebook.react:react-native:0.29.0' | |||
| compile 'com.facebook.react:react-native:+' | |||
There was a problem hiding this comment.
This has been discussed a lot in other issues, tl;dr: just revert it :)
There was a problem hiding this comment.
I figured this would be a no go. Is there a way we can make this library survive React Native upgrades without it though?
codenamev
added a commit
to reenhanced/react-native-maps
that referenced
this pull request
Jul 21, 2016
|
Closing. Addressed in #411. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few changes to make things work out of the box again.
Android:
rnpm(akareact-native link) in package.json to hookup settings to thelibfolder directly. Not quite sure why I had to do this. Perhaps it's a standard to live in theandroidfolder? It seems like we have two ways of linking... via source and via maven?iOS: