Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AirMapMarker to use loadImageWithURLRequest #389

Merged
merged 1 commit into from
Jul 13, 2016
Merged

Update AirMapMarker to use loadImageWithURLRequest #389

merged 1 commit into from
Jul 13, 2016

Commits on Jul 12, 2016

  1. Update AirMapMarker to use loadImageWithURLRequest 

    [`loadImageWithTag`](https://github.com/facebook/react-native/blob/ba4c34c0db004cda9fb561b3bdf5224d518ab32d/Libraries/Image/RCTImageLoader.m#L755) is deprecated and shows warnings on RN 0.29.

### Test Plan

On iOS, render a map with a marker that has image prop set. See marker is rendered correctly and no deprecation warnings.

```
<MapView ...>
  <MapView.Marker ... image={require('./pin.png')} />
</MapView>
```
    @paulshen
    paulshen committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    933ae51 View commit details
    Browse the repository at this point in the history