-
Notifications
You must be signed in to change notification settings - Fork 405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency nits plus a few questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency nits plus a few questions.
### Breaking | ||
|
||
- Removing <TextInput>'s `onTextInput` event ([3f7e0a2](https://github.com/facebook/react-native/commit/3f7e0a2) by [@shergin](https://github.com/shergin)) | ||
- Restore behavior for `underlayColor={null}` in `TouchableHighlight`. ([37d8440](https://github.com/facebook/react-native/commit/37d8440) by [@yungsters](https://github.com/yungsters)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I look through the change logs, I was a bit confused with this. New TouchableHighlight
was introduced in 0.62-rc.0
which had changed default behavior of underlayColor
. The default behavior has been restored also in 0.62-rc.0
. So, I am not sure if it's a part of breaking changes because anybody who would upgrade rn from published version could not recognize the difference. (I've tested this with 0.61-stable and 0.62-rc.1, and the result between the two is same).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this may have been a revert of behavior in which case both log lines should typically be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSavior sorry, I'm confused. Should I remove both "breaking" lines? Just the one about underlayColor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be better to keep the first one, which will be helpful for some people who have been using the event even not documented because it might be a breaking change for those people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this line, as it is essentially a revert that was a part of another commit (flagged as internal) that accidentally had a breaking change
Co-Authored-By: Ryan Turner <ryan@turnrye.com>
Co-Authored-By: Ryan Turner <ryan@turnrye.com>
Co-Authored-By: Ryan Turner <ryan@turnrye.com>
Co-Authored-By: Ryan Turner <ryan@turnrye.com>
Co-Authored-By: Ryan Turner <ryan@turnrye.com>
Thanks @turnrye for the review! I've updated the PR accordingly, and also updated it match rc1 |
Something we should call out is that in 0.62, it is required to specify either As part of this release we will also need to update the TypeScript types for that flag to mark it as required cc @alloy and @acoates-ms who have been working on getting TypeScript to support different types for patch releases. |
|
||
- Give ReactContextBaseJavaModule a 0 arg ctor ([e69be0a](https://github.com/facebook/react-native/commit/e69be0a) by [@RSNara](https://github.com/RSNara)) | ||
- Bump gradle-download-task to 4.0.2 ([088be26](https://github.com/facebook/react-native/commit/088be26) by [@dulmandakh](https://github.com/dulmandakh)) | ||
- Implement TurboModule eager initialization support ([b7f49a8](https://github.com/facebook/react-native/commit/b7f49a8) by [@RSNara](https://github.com/RSNara)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should TurboModule-related changes be in the changelog? Since TurboModules aren’t part of stable RN
|
||
### Added | ||
|
||
- Remove requestAnimationFrame when focusing input on mount ([5798cf2](https://github.com/facebook/react-native/commit/5798cf2) by [@janicduplessis](https://github.com/janicduplessis)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this got miscategorized as Added but should be in Fixed
|
||
### Removed | ||
|
||
- TouchableWithoutFeedback no longer exports Props; use React.ElementConfig instead ([7bcae81](https://github.com/facebook/react-native/commit/7bcae81) by [@yungsters](https://github.com/yungsters)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be removed. It's only relevant to Flow types which (and even more specifically, only the way we use them at FB)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some things that should maybe be added to the changelog. I got these by looking through the commit history in various parts of the repo, and I made changes to some of the commit messages for clarity.
### Added | ||
|
||
- Remove requestAnimationFrame when focusing input on mount ([5798cf2](https://github.com/facebook/react-native/commit/5798cf2) by [@janicduplessis](https://github.com/janicduplessis)) | ||
- Add missing `console` polyfills in release builds ([b7ab922](https://github.com/facebook/react-native/commit/b7ab922) by [@yungsters](https://github.com/yungsters)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add missing `console` polyfills in release builds ([b7ab922](https://github.com/facebook/react-native/commit/b7ab922) by [@yungsters](https://github.com/yungsters)) | |
- Integrate React DevTools v4 ([92a3c9d](https://github.com/facebook/react-native/commit/92a3c9d) by [@bvaughn](https://github.com/bvaughn)) | |
- Add Appearance native module ([63fa3f2](https://github.com/facebook/react-native/commit/63fa3f2) by [@hramos](https://github.com/hramos)) | |
- Export the DevSettings module, add `addMenuItem` method ([cc068b0](https://github.com/facebook/react-native/commit/cc068b0) by [@janicduplessis](https://github.com/janicduplessis)) | |
- Add support for native pseudo-OS to Platform.select ([a6fc089](https://github.com/facebook/react-native/commit/a6fc089) by [@koke](https://github.com/koke)) | |
- Add accessibilityValue support ([7df3eea](https://github.com/facebook/react-native/commit/7df3eea) by [@marcmulcahy](https://github.com/marcmulcahy)) | |
- Add missing `console` polyfills in release builds ([b7ab922](https://github.com/facebook/react-native/commit/b7ab922) by [@yungsters](https://github.com/yungsters)) |
Not sure if I should credit anyone else for Appearance, or if you also want to separately mention the addition of useColorScheme
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Most of those commits specify a Changelog in the commit summary. I'm surprised these didn't show up in the changelog originally, that seems like a bug. @jeremy-deutsch, maybe you'd like to also investigate that? The code for the changelog generator is here: https://github.com/react-native-community/releases/blob/master/changelog-generator.js
It's also fine if you don't want to do that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take a look, sure! If I had to guess, the problem probably stems from the fact that the GitHub API endpoint that the changelog generator script uses only gets the last 250 commits between the two versions. I'll let you know if I don't have time, either - thanks for giving me the out :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't think I'll have time for this, sorry! I tried having the script paginate through GitHub's API, but that gets you rate-limited pretty quick if you don't add authorization to the requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm taking this
- Fix Flipper integration on and update Flipper to 0.30.0 ([898b1db](https://github.com/facebook/react-native/commit/898b1db) by [@charpeni](https://github.com/charpeni)) | ||
- Add RCTUtilsUIOverride as a way to shortcut obtaining presentedViewController from sharedApplication to a supplied view controller for extensions ([2968450](https://github.com/facebook/react-native/commit/2968450)) | ||
|
||
### Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version bumps for important dependencies like the CLI, Metro, Hermes, and SoLoader should also go in Changed, I think. It's handy to be able to reference those other libraries' changelogs when upgrading.
|
||
### Breaking | ||
|
||
- Remove <TextInput>'s `onTextInput` event ([3f7e0a2](https://github.com/facebook/react-native/commit/3f7e0a2) by [@shergin](https://github.com/shergin)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The selectionState
prop was also removed from TextInput:
- Remove <TextInput>'s `onTextInput` event ([3f7e0a2](https://github.com/facebook/react-native/commit/3f7e0a2) by [@shergin](https://github.com/shergin)) | |
- Remove <TextInput>'s `onTextInput` event ([3f7e0a2](https://github.com/facebook/react-native/commit/3f7e0a2) by [@shergin](https://github.com/shergin)) | |
- Remove TextInput's `selectionState` Prop ([2becdfd](https://github.com/facebook/react-native/commit/2becdfd) by [@yungsters](https://github.com/yungsters)) |
|
||
#### Android specific | ||
|
||
- Give ReactContextBaseJavaModule a 0 argument constructor ([e69be0a](https://github.com/facebook/react-native/commit/e69be0a) by [@RSNara](https://github.com/RSNara)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Give ReactContextBaseJavaModule a 0 argument constructor ([e69be0a](https://github.com/facebook/react-native/commit/e69be0a) by [@RSNara](https://github.com/RSNara)) | |
- Implement fading edges for ScrollView and FlatList ([51aacd5](https://github.com/facebook/react-native/commit/51aacd5) by [@akrger](https://github.com/akrger)) | |
- Allow android modals to appear underneath a translucent status bar ([c35a419](https://github.com/facebook/react-native/commit/c35a419) by [@pfulop](https://github.com/pfulop)) | |
- Give ReactContextBaseJavaModule a 0 argument constructor ([e69be0a](https://github.com/facebook/react-native/commit/e69be0a) by [@RSNara](https://github.com/RSNara)) |
#### Android specific | ||
|
||
- Give ReactContextBaseJavaModule a 0 argument constructor ([e69be0a](https://github.com/facebook/react-native/commit/e69be0a) by [@RSNara](https://github.com/RSNara)) | ||
- Bump gradle-download-task to 4.0.2 ([088be26](https://github.com/facebook/react-native/commit/088be26) by [@dulmandakh](https://github.com/dulmandakh)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version bump should probably go under "Changed", not "Added"
- Reduce overhead of setting up timers in DEV ([75a154b](https://github.com/facebook/react-native/commit/75a154b) by [@motiz88](https://github.com/motiz88)) | ||
- Fix stack traces showing the wrong function name in some cases ([60b4ba1](https://github.com/facebook/react-native/commit/60b4ba1) by [@motiz88](https://github.com/motiz88)) | ||
- Don't crash when pretty-format is not available ([25a21b8](https://github.com/facebook/react-native/commit/25a21b8)) | ||
- TextInput now properly sends native the end selection location on change ([dff490d](https://github.com/facebook/react-native/commit/dff490d) by [@TheSavior](https://github.com/TheSavior)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- TextInput now properly sends native the end selection location on change ([dff490d](https://github.com/facebook/react-native/commit/dff490d) by [@TheSavior](https://github.com/TheSavior)) | |
- TextInput now properly sends native the end selection location on change ([dff490d](https://github.com/facebook/react-native/commit/dff490d) by [@TheSavior](https://github.com/TheSavior)) | |
- SectionSeparatorComponent and ItemSeparatorComponent display in the correct places inside an inverted SectionList ([dfb4f4a](https://github.com/facebook/react-native/commit/dfb4f4a) by [@dy93](https://github.com/dy93)) | |
- Fix a sporadic issue with VirtualizedList onEndReached called on load when not needed ([8ddf231](https://github.com/facebook/react-native/commit/8ddf231) by [@sahrens](https://github.com/sahrens)) |
- Slider is now disabled properly on iOS if the disabled prop is set ([fa9ff07](https://github.com/facebook/react-native/commit/fa9ff07)) | ||
- Reconnect to debugger websocket after metro is restarted ([13992f9](https://github.com/facebook/react-native/commit/13992f9) by [@rickhanlonii](https://github.com/rickhanlonii)) | ||
- Fix spinner visibility on beginRefreshingProgrammatically ([e341489](https://github.com/facebook/react-native/commit/e341489) by [@nnabinh](https://github.com/nnabinh)) | ||
- `Dimensions` module now updates on initial split screen ([e7c289b](https://github.com/facebook/react-native/commit/e7c289b) by [@sahrens](https://github.com/sahrens)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `Dimensions` module now updates on initial split screen ([e7c289b](https://github.com/facebook/react-native/commit/e7c289b) by [@sahrens](https://github.com/sahrens)) | |
- `Dimensions` module now updates on initial split screen ([e7c289b](https://github.com/facebook/react-native/commit/e7c289b) by [@sahrens](https://github.com/sahrens)) | |
- Fix animated gifs incorrectly looping ([6f2e6f1](https://github.com/facebook/react-native/commit/6f2e6f1) by [@zhongwuzw](https://github.com/zhongwuzw)) |
btw @alloy should we just kill this branch and re-generate the changelog using the new&improved script? I'm ok with that outcome |
@kelset Ah yes, that would be a good idea indeed. Do you wanna give it a try and provide feedback about the tool? |
Will do! Let's start by closing this one - sorry everyone, we'll try to keep track of your feedback for the followup PR 👍 |
This is the draft PR for the changelog of 0.62, based on the script
./changelog-generator.js -b v0.61.5 -c v0.62.0-rc.0
.I've started opening this so that we can start tweaking it/preparing it/remove any commits that should not be here, so that when we reach 0.62.0 the workload will be smaller.