Convert gradle scripts to Kotlin #14

dulmandakh · 2018-08-11T15:31:30Z

No description provided.

axe-fb · 2018-08-12T05:36:52Z

proposals/0003-gradle-kotlin-dsl.md

+
+This is not a breaking change because it affects only gradle scripts used to build RN for Android.
+
+I converted build.gradle and settings.gradle in root directory, see at


Should you link to specific files in the repo, so that they are easier to consume ?

axe-fb · 2018-08-12T05:37:22Z

proposals/0003-gradle-kotlin-dsl.md

+
+## Detailed design
+
+Convert only gradle scripts in ReactAndroid, and maybe RNTester, to Kotlin DSL, so we don't introduce breaking changes to RN based projects.


I think we should also consider scenarios where React Native is embedded into existing android apps. How will that work ?

We may also want to consider the changes coming in React Fabric and Turbo Modules. In both cases, there would be code-gen solutions, possible in JS. How would that integrate with the build system? These Code gen solutions are not finalized, so I may not yet have specific examples.

Also, we may need to run annotation processors, like ReactModuleInfoSpecProcessor that we don't run today. Should we address that also ?

axe-fb · 2018-08-12T05:40:16Z

proposals/0003-gradle-kotlin-dsl.md

+* auto-completion and content assist
+* quick documentation
+* navigation to source
+* refactoring and more


We don't need to explicitly list all the advantages here, linking to the official reason that Gradle has given may be sufficient.

axe-fb · 2018-08-12T05:40:57Z

proposals/0003-gradle-kotlin-dsl.md

+
+## Drawbacks
+
+Currently, RN use Gradle 4.4 which has partial but enough support for Kotlin DSL. Until we have 4.10, which has stable Kotlin DSL, we have to make sure that gradle scripts works and might require changes to work with landed Gradle version.


In this case, does it make sense to wait till Gradle 4.10 and then do the upgrade ?

That makes sense to me.

@dulmandakh - ping. What do you think about addressing this later when Gradle 4.10 comes around ?

gradle 6.7.1 is already out now, so how is it going

axe-fb · 2018-08-12T05:43:43Z

proposals/0003-gradle-kotlin-dsl.md

+
+## How we teach this
+
+This change won't affect RN based projects and RN developers, but RN core contributors. 


We should still consider how we can get core contributors up to speed here.

axe-fb · 2018-08-12T05:44:19Z

proposals/0003-gradle-kotlin-dsl.md

+* navigation to source
+* refactoring and more
+
+Also, nowadays there are more Android developers who knows Kotlin than Groovy.


Since this impacts only contributors, this would also require commitment from core contributors.

This should also impact all users of React Native with Android, as they also make changes to the gradle config in the template android project which is generated by RN.

dulmandakh · 2018-08-29T04:01:23Z

Thank you all for feedbacks, I'll try update my proposal ASAP to reflect the feedbacks and I'll do some research on questions.

jamonholmgren · 2018-09-08T17:17:29Z

proposals/0003-gradle-kotlin-dsl.md

+date: 2018-08-11
+---
+
+# RFC0003: Use Kotlin DSL in gradle scripts


I believe this is RFC0004.

cpojer · 2019-02-06T15:32:31Z

What's the status of this RFC? I think we use gradle 4.10+ now in RN so we can move ahead with this, no?

Legion2 · 2021-09-17T12:38:16Z

The usage of the old gradle script synctax such as buildscript and apply plugin is a huge blocker for us. Because RN dependencies are included as subprojects into the gradle project of tha apps, it forces the app developer(us) to also use the old syntax so that the gradle scripts are compatible.

We can not use the full kotlin dsl and features like pluginManagement and plugins dsl, because they do not work with the build.gradle files of react native projects.

There are no workarounds for the incompatibilities caused by the way react native uses gradle.

As a result react native is a blocker for the whole build tools ecosystem. No one can move forward without react native doing the first step to support the "new" gradle features and dropping the old syntax.

cortinico · 2021-09-17T14:58:49Z

As a result react native is a blocker for the whole build tools ecosystem. No one can move forward without react native doing the first step to support the "new" gradle features and dropping the old syntax.

Thanks for raising this point @Legion2.

We're currently working on revamping how we integrate with Gradle. Some of the work is already available inside https://github.com/facebook/react-native/tree/main/packages/react-native-gradle-plugin

Once that is fully released, you won't need a buildscript{} or the apply from react.gradle block anymore. You will be able to use the plugins{} block out of the box. On top of it, we've also worked on using the Gradle Lazy APIs and other improvements that will make RN less of a stranger in the Android/Gradle ecosystem.

EDIT: A more wider explanation on the direction we're taking with Gradle is described in detail by @fkgozali here #273

initial draft

6b5f566

axe-fb reviewed Aug 12, 2018

View reviewed changes

kelset added the 💡 Proposal This label identifies a proposal label Aug 12, 2018

jamonholmgren reviewed Sep 8, 2018

View reviewed changes

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert gradle scripts to Kotlin #14

Convert gradle scripts to Kotlin #14

dulmandakh commented Aug 11, 2018

axe-fb Aug 12, 2018

axe-fb Aug 12, 2018

axe-fb Aug 12, 2018

axe-fb Aug 12, 2018

axe-fb Aug 12, 2018

jamonholmgren Aug 13, 2018

axe-fb Aug 28, 2018

Legion2 Dec 6, 2020

axe-fb Aug 12, 2018

axe-fb Aug 12, 2018

Legion2 Dec 6, 2020

dulmandakh commented Aug 29, 2018

jamonholmgren Sep 8, 2018

cpojer commented Feb 6, 2019

Legion2 commented Sep 17, 2021

cortinico commented Sep 17, 2021 •

edited

Loading


		This is not a breaking change because it affects only gradle scripts used to build RN for Android.

		I converted build.gradle and settings.gradle in root directory, see at


		## Detailed design

		Convert only gradle scripts in ReactAndroid, and maybe RNTester, to Kotlin DSL, so we don't introduce breaking changes to RN based projects.


		## Drawbacks

		Currently, RN use Gradle 4.4 which has partial but enough support for Kotlin DSL. Until we have 4.10, which has stable Kotlin DSL, we have to make sure that gradle scripts works and might require changes to work with landed Gradle version.


		## How we teach this

		This change won't affect RN based projects and RN developers, but RN core contributors.

Convert gradle scripts to Kotlin #14

Convert gradle scripts to Kotlin #14

Conversation

dulmandakh commented Aug 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dulmandakh commented Aug 29, 2018

Choose a reason for hiding this comment

cpojer commented Feb 6, 2019

Legion2 commented Sep 17, 2021

cortinico commented Sep 17, 2021 • edited Loading

cortinico commented Sep 17, 2021 •

edited

Loading