-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ruby version check for RN CLI Doctor #1818
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ff62271
Ruby version check for RN CLI Doctor
arushikesarwani94 eb19da7
Ruby version check for RN CLI Doctor
arushikesarwani94 6a40272
Merge branch 'react-native-community:main' into main
arushikesarwani94 5806072
Merge branch 'main' of https://github.com/arushikesarwani94/cli
arushikesarwani94 45516d2
Merge branch 'main' of https://github.com/arushikesarwani94/cli
arushikesarwani94 2673703
Merge branch 'main' of https://github.com/arushikesarwani94/cli
arushikesarwani94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import versionRanges from '../versionRanges'; | ||
import {doesSoftwareNeedToBeFixed} from '../checkInstallation'; | ||
import {HealthCheckInterface} from '../../types'; | ||
|
||
export default { | ||
label: 'Ruby', | ||
isRequired: false, | ||
getDiagnostics: async ({Managers}) => ({ | ||
needsToBeFixed: doesSoftwareNeedToBeFixed({ | ||
version: Managers.RubyGems.version, | ||
versionRange: versionRanges.RUBY, | ||
}), | ||
version: Managers.RubyGems.version, | ||
versionRange: versionRanges.RUBY, | ||
}), | ||
runAutomaticFix: async ({loader, logManualInstallation}) => { | ||
loader.fail(); | ||
|
||
logManualInstallation({ | ||
healthcheck: 'Ruby', | ||
url: 'https://reactnative.dev/docs/environment-setup#ruby', | ||
}); | ||
}, | ||
} as HealthCheckInterface; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arushikesarwani, when I go to https://reactnative.dev/docs/environment-setup#ruby it only takes me to the correct place if I have previously opened the "React Native CLI Quickstart" tab (and all the other tabs underneath it) and the Ruby heading is visible. Otherwise it is a broken link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, unfortunately, that's a problem with the current website and how docusaurus handles deeplink with tabs. I think we need to change the website design to ease the usage of links with anchors like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think its related to #1767