feat(core): styled-components v2 update #1775

justingreenberg · 2017-05-25T18:22:55Z

updates project to use to styled-components v2 🎉

i'm thinking we should probably update deps and cut a release soon...

edit: congrats on the release @mxstbr!! https://www.styled-components.com/

coveralls · 2017-05-25T18:27:07Z

Coverage remained the same at 99.242% when pulling b4074b5 on feat/styled-components-v2 into cfe0c7c on dev.

coveralls · 2017-05-27T17:19:23Z

Coverage remained the same at 99.242% when pulling 680f333 on feat/styled-components-v2 into f813fb6 on dev.

coveralls · 2017-05-27T17:19:23Z

Coverage remained the same at 99.242% when pulling 680f333 on feat/styled-components-v2 into f813fb6 on dev.

coveralls · 2017-05-27T17:42:18Z

Coverage remained the same at 99.231% when pulling 31e0295 on feat/styled-components-v2 into 88616ce on dev.

coveralls · 2017-05-27T20:06:51Z

Coverage remained the same at 99.231% when pulling a51028a on feat/styled-components-v2 into a2173a2 on dev.

gihrig

Looks great on a quick review and build. All modified components render as expected 😄

I have not taken the time to get in-depth on what is new in styled-components 2.0.0

mihir0x69 · 2017-05-28T11:04:30Z

@justingreenberg Just a small query. Is babel-plugin-styled-components necessary? Because it says-

This plugin is only necessary if you're server-side rendering, you can use styled-components perfectly fine without it!

And we're not supporting ssr atm.

Dattaya · 2017-05-28T13:43:23Z

@KarandikarMihir, it doesn't look useful at the moment but it could be in the future once minification is no longer an experimental feature, so I'm going to give this a thumbs up, but if this plugin is removed I'm fine with that too.

Dattaya · 2017-05-28T14:02:08Z

@KarandikarMihir, I've read the description of babel-plugin-styled-components again and it says that it's fine to enable minification in production as long as it's enabled in development as well, so I think this plugin is useful after all.

Dattaya · 2017-05-28T13:54:44Z

package.json

@@ -248,6 +251,7 @@
    "babel-plugin-dynamic-import-node": "1.0.0",
    "babel-plugin-react-intl": "2.3.1",
    "babel-plugin-react-transform": "2.0.2",
+    "babel-plugin-styled-components": "^1.1.4",


Previous convention was not to use semver symbols like caret (^) in package.json

Dattaya · 2017-05-28T14:15:03Z

@justingreenberg, I have one nitpick, otherwise, nicely done 👍
I've tested your branch and everything seems to be fine (to be more precise, spotted some bugs but they're unrelated to this PR)

coveralls · 2017-05-28T14:20:03Z

Coverage remained the same at 99.231% when pulling 894869f on feat/styled-components-v2 into 5ec8dd4 on dev.

justingreenberg · 2017-05-28T16:31:56Z

@KarandikarMihir & @Dattaya thank you guys!

Re: the plugin - I added it primarily to generate displayName (for use with devtools):

This babel plugin adds the components' name to the class name attached to the DOM node. In your browser's DevTools you'll see <button class="sc-Button-asdf123 asdf123" /> instead of just <button class="asdf123" />.

This also adds support for showing your components' real name in the React DevTools. They will normally show <styled.button> for all of your components, but with this plugin they show <MyButton />.

This makes it easier to find your components and to figure out where they live in your app.

ref: https://github.com/styled-components/babel-plugin-styled-components#better-debugging

preprocessing will be a very cool feature, but I would wait until it stabilizes before turning on

edit: @Dattaya locked package version :)

coveralls · 2017-05-28T16:34:25Z

Coverage remained the same at 99.237% when pulling 7572e0f on feat/styled-components-v2 into 24de895 on dev.

coveralls · 2017-05-28T16:37:32Z

Coverage remained the same at 99.237% when pulling 7572e0f on feat/styled-components-v2 into 24de895 on dev.

mihir0x69 · 2017-05-28T16:41:26Z

@justingreenberg @Dattaya Alright! Thanks for clearing that up for me. Let's 🚢 😄

sam-ghosh · 2017-06-20T01:16:48Z

Hello guys, I am trying to use styled-components v2 in the react boilerplate 3.4 (why? because of the better debugging in inspect tools - https://github.com/styled-components/babel-plugin-styled-components#better-debugging) ... I have done all the changes as indicated here in this PR - however it seems that I am getting an error

index.js:7 Uncaught TypeError: 
WEBPACK_IMPORTED_MODULE_0_styled_components.default.a.withConfig is not a function
at Object../app/components/A/index.js (index.js:7)

which is the following line -

const A = styled.a

seems like the styled function is not working any more. This issue goes away when I remove the babel plugin, but then I end up with cryptic class names that dont help debugging

Dattaya · 2017-06-21T19:33:21Z

@somghosh, what is the result of:

> npm ls styled-components

also, that line looks wrong, it should be

const A = styled.a`

sam-ghosh · 2017-06-25T13:00:59Z

Hi @Dattaya

> npm ls styled-components

gives

react-boilerplate@3.4.0 /Users/somghosh/Programming/xeniajs
├── styled-components@2.1.0
└── UNMET PEER DEPENDENCY webpack@2.2.0-rc.3

npm ERR! peer dep missing: webpack@^1.11.0 || ^2.1.0-beta || ^2.1.0, required by eslint-import-resolver-webpack@0.8.0
npm ERR! peer dep missing: webpack@1 || ^2.1.0-beta, required by html-webpack-plugin@2.24.1

And yes,

const A = styled.a`

This is exactly what I am doing, sorry for the typo

Dattaya · 2017-06-25T13:55:21Z

@somghosh, I can see that you have outdated webpack 2 RC. In this case I recommend you to use the dev branch, it's the same as master but with updated dependencies.

sam-ghosh · 2017-06-25T14:42:30Z

Thanks, yes I figured out thats the case as well. I updated to webpack webpack@2.6.1 -- and what is now happening is the styled-component is adding a 'sc-' prefixed classname, but the remaining part of that classname is still another random text

Using the dev branch might introduce more uncertainties maybe - I simply want nice debuggable classNames in the Developer Console

sam-ghosh · 2017-06-25T14:45:17Z

Can I kindly ask @Dattaya if, when you made this pull request (and was merged), you were seeing "nice" classnames being produced by styled component?

As I said, I upgraded to webpack 2.6.1 and what I am seeing is as below

mxstbr · 2017-06-25T14:50:33Z

Can you run cat node_modules/styled-components/package.json | grep version ? If you use the Babel plugin with any 2.x version (apart from some pre-releases) it should work.

sam-ghosh · 2017-06-25T15:04:57Z

"version": "2.1.0",

also "babel-plugin-styled-components": "^1.1.5",

sam-ghosh · 2017-06-25T15:05:48Z

thanks @mxstbr , I think it is working in terms of adding the new className, just not a "nice" classname

sam-ghosh · 2017-06-25T16:12:21Z

Apologies @mxstbr @Dattaya - this works now, I seem to have forgotten to put in the

"plugins": [
 +      "styled-components"
 +    ],

bit after making several changes.

I also quickly checked that this is not in the dev branch code in package.json - maybe we should put that in to get the most out of styled-components

Dattaya · 2017-06-25T19:05:00Z

@somghosh I'm glad to hear you figured it all out 👍

I also quickly checked that this is not in the dev

I think it is: https://github.com/react-boilerplate/react-boilerplate/blob/dev/package.json#L52

* Docs Update: sass.md | New webpack version -loader suffix (#1484) * New webpack version -loader suffix New webpack version no longer allowed to omit the '-loader' suffix when using loaders. * Webpack 2 migration module.loaders => module.rules * Fix Loaders/Rules * chore(docs): fix link to redux-saga docs Fix a broken link to redux-saga docs. * feat(webpack): Support OpenType fonts with .otf file extension (#1471) * chore(docs): improve testing documentation * [doc] improve code snippet syntax in unit-testing doc linted code snippet and removed uneeded import * [doc] add overview of reducer test in unit testing doc add the completed reducer test file as overview in unit testing documentation * [doc] improve component testing doc linted code snippets, added complete test file as refernce and link to next doc page. * chore(setup): remove LGTM config files (#1317) * chore(setup): remove LGTM * Add collaborating guidelines * Add @KarandikarMihir * Remove .react.js extensions (#1469) * Remove .react.js extensions * Restore file names in the title comments * Remove hyphens * chore(deps): update deps roll-up Jan-21-2017 (#1501) * fix(tests): Replace sinon restore (#1512) * Remove sinon.restore() * Lock down sinon version * chore(all): move to an organisation on GitHub * Make webpack build less verbose (#1510) * removed route names from app/routes (#1509) * removed route names from app/routes * removed name prop from internals/templates/routes * removed name from internals/gens/route/route.hbs and routeWithReducer.hbs * fix(eslint): Enable rule react/no-array-index-key (#1521) * enable rule react/no-array-index-key * fix test of List component * fix(dependencies.js): clean up console clutter for install scripts (#1532) Ref #1506 * Fix typo i18n.md (#1541) * chore(deps): update deps roll-up Jan-28-2017 (#1531) * chore(deps): update deps roll-up Jan-28-2017 * Update package.json * Set history@3.2.1 * Using optimised version of the banner (#1560) Taken from #907 * test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563) * Update docs (README.md, Gotchas.md) (#1534) * Update README.md * Update gotchas.md * Add links to gotchas * Update docs * Remove redundant sentence * Move reinstall steps to gotchas.md * Update README.md * Minor corrections * Add jest cache clean to gotchas.md * Fix team of devs link (#1566) * chore(deps): update deps roll-up Feb-04-2017 (#1561) * Add iOS home screen icon (#1585) * fix manifest icons (#1568) * manifest(fix) (#1594) * Change dev source map style (#1559) * (fix) ProgressBar state error (#1553) * Bind listener to the current instance of component * Bring up coverage * Reassign listener with newly bound listener * Minor changes * Separated dev and prod middlewares (#1556) * Update FAQ with Styles getting overridden (#1592) * Improve <List> tests (#1134) * Fix imported styles (#1599) * Migrate webpack loaders * Add comment to CSS loader This should help clarify and reduce common problems * Split css rules into two * Updated docs * First draft of new styling docs * Fix Sass heading * Fix links and wording * Add LESS and other improvements * Post test fixes * Updated headings and added more info section * fix: Intl polyfill for language generator (#1611) * fix: Intl polyfill for language generator * fix: appveyor chrome issue by adding suggested --ignore-checksums * Fix broken link in documentation. Fixes #1638. (#1643) * refactor(react-router-scroll): Import only useScroll (#1609) * chore(package.json): sort ESLint config (#1660) This PR will sort the ESLint configuration alphabetically in `package.json`. * Fix iOS home screen icons (#1604) * Use absolute paths * AppVeyor install chrome ignoring checksums * Add Stateless Functions to Container Generator (#1494) * Add Stateless Functions to Container Generator * Fix linting test for generators * Tightened up generator type names - Also made component and container use similar order and language * Fix odd node5 issue * and disable eslint for the var * Fix missing reference (#1725) * Moving Contrib documentation to the right place (#1721) * refactor(react-router): Import only necessary components (#1608) Instead of importing the entire library, cherry-pick the components we use. This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router. Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB). * Fixing links for the contributing.md (#1738) * a grammatical item (#1740) * Remove state update in componentWillUpdate (#1769) * syntatical improvements to progress bar (#1633) * syntatical improvements to progress bar * declare propTypes and defaultProps on the class instead of using the static keyword * Improve the setup to recognize our own repo before clearing it. (#1720) * Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719) * Cleaning up console messages upon setup * Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719 * Fixing the scenario where it was not exiting this file after not removing the repository * Doing minor changes suggested * Updating quickstart file location (#1712) * Request utils: handle 204 and 205 HTTP response (#1780) * feat(core): styled-components v2 update (#1775) * feat(core): styled-components v2 update * fix(deps): lock version for styled plugin * Fix: Use local instance of shelljs (#1782) * Use local instance of shelljs * Replace var with const * Switching deprecated babel-preset-latest to babel-preset-env (#1736) * adding babel-preset-env package * replacing deprecated babel-preset-latest with babel-preset-env to avoid the following npm installation warning: ``` npm WARN deprecated babel-preset-latest@6.24.0: preset-latest accomplishes the same task as babel-preset-env. Please install it with 'npm install babel-preset-env --save-dev'. '{ "presets": ["latest"] }' to '{ "presets": ["env"] }'. For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env ``` Ref. #1667 * removing deprecated babel-preset-latest package * Add missing word (#1789) * Migrating from React.PropTypes to PropTypes (#1787) * adding prop-types dependency * migrating from React.PropTypes to PropTypes * Adding some tests (#1784) * tests(FeaturePage): testing shouldComponentUpdate function * tests(HomePage): testing if username prop is missing * tests(ProgressBar): testing when route is not changing * tests: removing global-styles.js from coverage collect * tests(Toggle): adding tests for empty values prop * tests(store): adding missing tests * tests(ProgressBar): adding missing tests * chore(deps): update deps roll-up Jun-01-2017 (#1794) * chore(deps): update deps roll-up Jun-01-2017 * Add react-test-renderer as dev dependency * Remove `react-addons-test-utils` * Use new `react-helmet` API * Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.' Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.' * Revert line that wasn't meant to be commited * docs(maintenance): Create dependency update doc (#1790) * docs(maintenance): Create dependency update doc * Update dependency.md * Update dependency.md * Update dependency.md * Update dependency.md * Add link to #598 * Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824) * feat(core): React Router v4, React-Loadable, asyncInjectors (#1746) * Migrate to react router v4. * Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact. * Fix route generator. * Implicitly pass store into loader from AsyncRoute to simplify custom child route components. * Fix route prop propagation. * Regen yarn.lock * Keep track of route loading in redux state and read in progress bar. * Replace AsyncRoute with react-loadable * Add `DefaultLoadingComponentProvider` * Rename `loader.js` to `Loadable.js` * Revert 9f44f1b * small chores * Add tests * Update generators * Exclude component/Loadable from coverage * Update docs * Make App a class that extends React.Component to enable hot reloading * Add a link to RR4 API * Improve generators * Fix linting errors * Update react-loadable * Update yarn.lock * Propagate InnerLoadable props to the rendered component, for Route props like match. * Refactor * rename withMappedState -> withConnect * rename name to key * Use constants * Make 'daemon' a default mode for `injectReducer` * Simplify `ejectSaga` * Improve docs * clean up * recommend to use `ConnectedSwitch` * turn `App` into a function like it was before * Run CI * Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router` * Remove path from a 'not found' route * Update deps * Simplify tests * Remove modes from `injectReducer` * Make second argument to be a descriptor in `sagaInjectors` * Change `constants` to have consistent values * Remove non-daemon saga descriptors in production in `ejectSaga` * Save an entire descriptor in the saga registry * Fix `constants` in templates * fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871) * Replace react-hmre with bare webpack hmr * Explicitly unmount the main component * Prevent recomputing reducers for `replaceReducer` * Add a link to Wepack HMR to the docs * Remove `overlay=true` * Accept an array of modules to hot reload * Add Debugging section in Docs + VS Code instructions (#1698) * Add debugging section in README * Move WebStorm FAQ to debugging section * Add VS Code to debugging section * Update VS Code launch config * Update VS Code config to work in dev branch * Add VS Code launch.json config * Update launch.json to be compatible with master * Update VS Code launch to be compatible with master * Remove .vscode launch config * Add notice on source map issue for VS Code. * move onSubmitForm test into mapDispatchToProps test (#1644) * Use camelcase for reducer and saga key to match selector. (#1888) * chore(deps): remove unusable deps sinon (#1882) * chore(deps): downgrade `sanitize.css` (#1872) * chore(templates): turn `App` into a functional component (#1892) Fixes #1884 * fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873) * Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904) * Rename store.js to configureStore.js to Prevent conflict with storeJS npm package * Fix store -> configureStore * Bump webpack to 3.0.0 and update related deps (#1823) * Bump webpack to 3.0.0 and related deps * Add ModuleConcatenationPlugin to webpack base config * Check in mysterious change in yarn.lock * Install latest html-webpack-plugin and resolve incorrect peer dep issue * Update webpack to 3.5.4 * Bump webpack to 3.5.5 * Move ModuleConcatenationPlugin from base to prod config, add --display-optimization-bailout flag * Serve Dlls via add-asset-html-webpack-plugin (#1849) * Serve Dlls via add-asset-html-webpack-plugin * Remove duplicate dll script tags and cheerio dependency * Remove cheerio refs from docs * Minor whitespace change * Remove eslint exception in webpack.dll.babel.js * chore(deps): Upgrade React to v15.6 (#1832) * chore(deps): regenerate `yarn.lock` (#1931) * chore(deps): regenerate `yarn.lock` * Empty commit to restart netlify * chore(3.5): Update changelog.md

* Merge v3.5 release (#1929) * Docs Update: sass.md | New webpack version -loader suffix (#1484) * New webpack version -loader suffix New webpack version no longer allowed to omit the '-loader' suffix when using loaders. * Webpack 2 migration module.loaders => module.rules * Fix Loaders/Rules * chore(docs): fix link to redux-saga docs Fix a broken link to redux-saga docs. * feat(webpack): Support OpenType fonts with .otf file extension (#1471) * chore(docs): improve testing documentation * [doc] improve code snippet syntax in unit-testing doc linted code snippet and removed uneeded import * [doc] add overview of reducer test in unit testing doc add the completed reducer test file as overview in unit testing documentation * [doc] improve component testing doc linted code snippets, added complete test file as refernce and link to next doc page. * chore(setup): remove LGTM config files (#1317) * chore(setup): remove LGTM * Add collaborating guidelines * Add @KarandikarMihir * Remove .react.js extensions (#1469) * Remove .react.js extensions * Restore file names in the title comments * Remove hyphens * chore(deps): update deps roll-up Jan-21-2017 (#1501) * fix(tests): Replace sinon restore (#1512) * Remove sinon.restore() * Lock down sinon version * chore(all): move to an organisation on GitHub * Make webpack build less verbose (#1510) * removed route names from app/routes (#1509) * removed route names from app/routes * removed name prop from internals/templates/routes * removed name from internals/gens/route/route.hbs and routeWithReducer.hbs * fix(eslint): Enable rule react/no-array-index-key (#1521) * enable rule react/no-array-index-key * fix test of List component * fix(dependencies.js): clean up console clutter for install scripts (#1532) Ref #1506 * Fix typo i18n.md (#1541) * chore(deps): update deps roll-up Jan-28-2017 (#1531) * chore(deps): update deps roll-up Jan-28-2017 * Update package.json * Set history@3.2.1 * Using optimised version of the banner (#1560) Taken from #907 * test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563) * Update docs (README.md, Gotchas.md) (#1534) * Update README.md * Update gotchas.md * Add links to gotchas * Update docs * Remove redundant sentence * Move reinstall steps to gotchas.md * Update README.md * Minor corrections * Add jest cache clean to gotchas.md * Fix team of devs link (#1566) * chore(deps): update deps roll-up Feb-04-2017 (#1561) * Add iOS home screen icon (#1585) * fix manifest icons (#1568) * manifest(fix) (#1594) * Change dev source map style (#1559) * (fix) ProgressBar state error (#1553) * Bind listener to the current instance of component * Bring up coverage * Reassign listener with newly bound listener * Minor changes * Separated dev and prod middlewares (#1556) * Update FAQ with Styles getting overridden (#1592) * Improve <List> tests (#1134) * Fix imported styles (#1599) * Migrate webpack loaders * Add comment to CSS loader This should help clarify and reduce common problems * Split css rules into two * Updated docs * First draft of new styling docs * Fix Sass heading * Fix links and wording * Add LESS and other improvements * Post test fixes * Updated headings and added more info section * fix: Intl polyfill for language generator (#1611) * fix: Intl polyfill for language generator * fix: appveyor chrome issue by adding suggested --ignore-checksums * Fix broken link in documentation. Fixes #1638. (#1643) * refactor(react-router-scroll): Import only useScroll (#1609) * chore(package.json): sort ESLint config (#1660) This PR will sort the ESLint configuration alphabetically in `package.json`. * Fix iOS home screen icons (#1604) * Use absolute paths * AppVeyor install chrome ignoring checksums * Add Stateless Functions to Container Generator (#1494) * Add Stateless Functions to Container Generator * Fix linting test for generators * Tightened up generator type names - Also made component and container use similar order and language * Fix odd node5 issue * and disable eslint for the var * Fix missing reference (#1725) * Moving Contrib documentation to the right place (#1721) * refactor(react-router): Import only necessary components (#1608) Instead of importing the entire library, cherry-pick the components we use. This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router. Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB). * Fixing links for the contributing.md (#1738) * a grammatical item (#1740) * Remove state update in componentWillUpdate (#1769) * syntatical improvements to progress bar (#1633) * syntatical improvements to progress bar * declare propTypes and defaultProps on the class instead of using the static keyword * Improve the setup to recognize our own repo before clearing it. (#1720) * Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719) * Cleaning up console messages upon setup * Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719 * Fixing the scenario where it was not exiting this file after not removing the repository * Doing minor changes suggested * Updating quickstart file location (#1712) * Request utils: handle 204 and 205 HTTP response (#1780) * feat(core): styled-components v2 update (#1775) * feat(core): styled-components v2 update * fix(deps): lock version for styled plugin * Fix: Use local instance of shelljs (#1782) * Use local instance of shelljs * Replace var with const * Switching deprecated babel-preset-latest to babel-preset-env (#1736) * adding babel-preset-env package * replacing deprecated babel-preset-latest with babel-preset-env to avoid the following npm installation warning: ``` npm WARN deprecated babel-preset-latest@6.24.0: preset-latest accomplishes the same task as babel-preset-env. Please install it with 'npm install babel-preset-env --save-dev'. '{ "presets": ["latest"] }' to '{ "presets": ["env"] }'. For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env ``` Ref. #1667 * removing deprecated babel-preset-latest package * Add missing word (#1789) * Migrating from React.PropTypes to PropTypes (#1787) * adding prop-types dependency * migrating from React.PropTypes to PropTypes * Adding some tests (#1784) * tests(FeaturePage): testing shouldComponentUpdate function * tests(HomePage): testing if username prop is missing * tests(ProgressBar): testing when route is not changing * tests: removing global-styles.js from coverage collect * tests(Toggle): adding tests for empty values prop * tests(store): adding missing tests * tests(ProgressBar): adding missing tests * chore(deps): update deps roll-up Jun-01-2017 (#1794) * chore(deps): update deps roll-up Jun-01-2017 * Add react-test-renderer as dev dependency * Remove `react-addons-test-utils` * Use new `react-helmet` API * Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.' Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.' * Revert line that wasn't meant to be commited * docs(maintenance): Create dependency update doc (#1790) * docs(maintenance): Create dependency update doc * Update dependency.md * Update dependency.md * Update dependency.md * Update dependency.md * Add link to #598 * Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824) * feat(core): React Router v4, React-Loadable, asyncInjectors (#1746) * Migrate to react router v4. * Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact. * Fix route generator. * Implicitly pass store into loader from AsyncRoute to simplify custom child route components. * Fix route prop propagation. * Regen yarn.lock * Keep track of route loading in redux state and read in progress bar. * Replace AsyncRoute with react-loadable * Add `DefaultLoadingComponentProvider` * Rename `loader.js` to `Loadable.js` * Revert 9f44f1b * small chores * Add tests * Update generators * Exclude component/Loadable from coverage * Update docs * Make App a class that extends React.Component to enable hot reloading * Add a link to RR4 API * Improve generators * Fix linting errors * Update react-loadable * Update yarn.lock * Propagate InnerLoadable props to the rendered component, for Route props like match. * Refactor * rename withMappedState -> withConnect * rename name to key * Use constants * Make 'daemon' a default mode for `injectReducer` * Simplify `ejectSaga` * Improve docs * clean up * recommend to use `ConnectedSwitch` * turn `App` into a function like it was before * Run CI * Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router` * Remove path from a 'not found' route * Update deps * Simplify tests * Remove modes from `injectReducer` * Make second argument to be a descriptor in `sagaInjectors` * Change `constants` to have consistent values * Remove non-daemon saga descriptors in production in `ejectSaga` * Save an entire descriptor in the saga registry * Fix `constants` in templates * fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871) * Replace react-hmre with bare webpack hmr * Explicitly unmount the main component * Prevent recomputing reducers for `replaceReducer` * Add a link to Wepack HMR to the docs * Remove `overlay=true` * Accept an array of modules to hot reload * Add Debugging section in Docs + VS Code instructions (#1698) * Add debugging section in README * Move WebStorm FAQ to debugging section * Add VS Code to debugging section * Update VS Code launch config * Update VS Code config to work in dev branch * Add VS Code launch.json config * Update launch.json to be compatible with master * Update VS Code launch to be compatible with master * Remove .vscode launch config * Add notice on source map issue for VS Code. * move onSubmitForm test into mapDispatchToProps test (#1644) * Use camelcase for reducer and saga key to match selector. (#1888) * chore(deps): remove unusable deps sinon (#1882) * chore(deps): downgrade `sanitize.css` (#1872) * chore(templates): turn `App` into a functional component (#1892) Fixes #1884 * fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873) * Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904) * Rename store.js to configureStore.js to Prevent conflict with storeJS npm package * Fix store -> configureStore * Bump webpack to 3.0.0 and update related deps (#1823) * Bump webpack to 3.0.0 and related deps * Add ModuleConcatenationPlugin to webpack base config * Check in mysterious change in yarn.lock * Install latest html-webpack-plugin and resolve incorrect peer dep issue * Update webpack to 3.5.4 * Bump webpack to 3.5.5 * Move ModuleConcatenationPlugin from base to prod config, add --display-optimization-bailout flag * Serve Dlls via add-asset-html-webpack-plugin (#1849) * Serve Dlls via add-asset-html-webpack-plugin * Remove duplicate dll script tags and cheerio dependency * Remove cheerio refs from docs * Minor whitespace change * Remove eslint exception in webpack.dll.babel.js * chore(deps): Upgrade React to v15.6 (#1832) * chore(deps): regenerate `yarn.lock` (#1931) * chore(deps): regenerate `yarn.lock` * Empty commit to restart netlify * chore(3.5): Update changelog.md * chore(deps): Bump version to 3.5.0 * fix(internals): Update RBP version string in internal config (#2002) closes #2001 * Correct babel plugin order here is related issue comment: babel/babel#5325 (comment) * fix incorrect merge

lock · 2018-05-29T03:19:48Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

feat(core): styled-components v2 update

b4074b5

justingreenberg added the enhancement label May 25, 2017

justingreenberg requested review from Dattaya and gihrig May 25, 2017 18:22

justingreenberg added this to the v3.5 milestone May 25, 2017

justingreenberg self-assigned this May 25, 2017

justingreenberg requested review from mxstbr and removed request for Dattaya and mxstbr May 25, 2017 18:34

Merge branch 'dev' into feat/styled-components-v2

680f333

Merge branch 'dev' into feat/styled-components-v2

31e0295

Merge branch 'dev' into feat/styled-components-v2

a51028a

gihrig approved these changes May 27, 2017

View reviewed changes

Dattaya requested changes May 28, 2017

View reviewed changes

Merge branch 'dev' into feat/styled-components-v2

894869f

justingreenberg added 2 commits May 28, 2017 12:26

fix(deps): lock version for styled plugin

2f2a08b

Merge branch 'dev' into feat/styled-components-v2

7572e0f

Dattaya approved these changes May 28, 2017

View reviewed changes

Dattaya merged commit 48fef62 into dev May 28, 2017

Dattaya deleted the feat/styled-components-v2 branch May 28, 2017 17:20

justingreenberg mentioned this pull request Jun 19, 2017

Styled-components doesn't work partially. (extend, attrs) #1808

Closed

2 tasks

lock bot locked as resolved and limited conversation to collaborators May 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): styled-components v2 update #1775

feat(core): styled-components v2 update #1775

justingreenberg commented May 25, 2017 •

edited

Loading

coveralls commented May 25, 2017 •

edited

Loading

coveralls commented May 27, 2017

coveralls commented May 27, 2017 •

edited

Loading

coveralls commented May 27, 2017 •

edited

Loading

coveralls commented May 27, 2017 •

edited

Loading

gihrig left a comment

mihir0x69 commented May 28, 2017

Dattaya commented May 28, 2017

Dattaya commented May 28, 2017

Dattaya May 28, 2017

Dattaya commented May 28, 2017

coveralls commented May 28, 2017 •

edited

Loading

justingreenberg commented May 28, 2017 •

edited

Loading

coveralls commented May 28, 2017 •

edited

Loading

coveralls commented May 28, 2017 •

edited

Loading

mihir0x69 commented May 28, 2017

sam-ghosh commented Jun 20, 2017 •

edited

Loading

Dattaya commented Jun 21, 2017

sam-ghosh commented Jun 25, 2017 •

edited

Loading

Dattaya commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

mxstbr commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

Dattaya commented Jun 25, 2017

lock bot commented May 29, 2018

feat(core): styled-components v2 update #1775

feat(core): styled-components v2 update #1775

Conversation

justingreenberg commented May 25, 2017 • edited Loading

coveralls commented May 25, 2017 • edited Loading

coveralls commented May 27, 2017

coveralls commented May 27, 2017 • edited Loading

coveralls commented May 27, 2017 • edited Loading

coveralls commented May 27, 2017 • edited Loading

gihrig left a comment

Choose a reason for hiding this comment

mihir0x69 commented May 28, 2017

Dattaya commented May 28, 2017

Dattaya commented May 28, 2017

Dattaya May 28, 2017

Choose a reason for hiding this comment

Dattaya commented May 28, 2017

coveralls commented May 28, 2017 • edited Loading

justingreenberg commented May 28, 2017 • edited Loading

coveralls commented May 28, 2017 • edited Loading

coveralls commented May 28, 2017 • edited Loading

mihir0x69 commented May 28, 2017

sam-ghosh commented Jun 20, 2017 • edited Loading

Dattaya commented Jun 21, 2017

sam-ghosh commented Jun 25, 2017 • edited Loading

Dattaya commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

mxstbr commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

sam-ghosh commented Jun 25, 2017

Dattaya commented Jun 25, 2017

lock bot commented May 29, 2018

justingreenberg commented May 25, 2017 •

edited

Loading

coveralls commented May 25, 2017 •

edited

Loading

coveralls commented May 27, 2017 •

edited

Loading

coveralls commented May 27, 2017 •

edited

Loading

coveralls commented May 27, 2017 •

edited

Loading

coveralls commented May 28, 2017 •

edited

Loading

justingreenberg commented May 28, 2017 •

edited

Loading

coveralls commented May 28, 2017 •

edited

Loading

coveralls commented May 28, 2017 •

edited

Loading

sam-ghosh commented Jun 20, 2017 •

edited

Loading

sam-ghosh commented Jun 25, 2017 •

edited

Loading