-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable ssldir creation target for openssl install #1973
Conversation
Prior commit attempts to shorten install by omitting documentation install, however an additional target is needed to get the conf dirs for capturing the PEMs et al.
@jpr5 Thank you! The fix looks good to me. |
In openssl 1.0.2 (the oldest version used in ruby-build), there appears to be no So that seems an issue, as we'd break those (e.g., 2.3.8). |
I should have started with: Thank you for the fix and sorry for breaking that (at least it's not on a ruby-build release). |
@eregon If we cannot reliably support all OpenSSL versions that we use, then we should revert #1967. If compilation speed is an issue, the ultimate solution would be that ruby-build doesn't compile openssl in the first place #1974 (comment) |
@mislav I'll make my own PR to try to fix this ASAP.
The cases I let ruby-build compile openssl is the cases I would need to somehow compile openssl anyway. But maybe on macOS we could default to use Homebrew's openssl, or the system openssl if it's usable nowadays. |
I confirmed: So we just need a check for openssl < 1.1 |
Prior commit attempts to shorten install by omitting documentation install,
however an additional target is needed to get the conf dirs for capturing the
PEMs et al.
Solves issue mentioned in discussion 1972.
Related to #1967