Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark maglev as EoL #1420

Merged
merged 1 commit into from
Dec 3, 2020
Merged

mark maglev as EoL #1420

merged 1 commit into from
Dec 3, 2020

Conversation

metalefty
Copy link
Contributor

as the last commit of mavlev is over 3 years ago

Discussed at: #1402 (comment)

as the last commit of mavlev is over 3 years ago

Discussed at: rbenv#1402 (comment)
Copy link
Member

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as a mechanism to hide maglev from the list of currently maintained Ruby versions, but I'm curious whether we are using the wrong label for it? When something is "EoL", it's always because the maintainer of the software has proclaimed it to be so. I feel that we are in no position to label something as "EoL", even though by all accounts it does not seem maintained anymore.

Has there been any official announcement of stopping Maglev development?

@metalefty
Copy link
Contributor Author

Good point. I also think "EoL" should be based on official announcements. Marking maglev as warn_eol a little bit misnomer. AFAIK, there's no official announcements from Maglev team.

I suggested alternate warn_abandoned tag in #1402 (comment) . I think this is better to describe current mavlev state. However, I feel implementing warn_abandoned only to hide mavlev from the list is not worth the effort. That's the reason of this PR. IMO, I know marking maglev as warn_eol is not best but an acceptable workaround.

Differences between warn_*:

  • warn_eol
    • officially announced as EoL
  • warn_abandoned (suggested by me)
    • considered as abandoned
    • no active developments for a long time with no official announcements

@jasonkarns jasonkarns changed the title mark mavlev as EoL mark maglev as EoL Apr 12, 2020
@hsbt
Copy link
Member

hsbt commented Dec 3, 2020

I decided to merge this. The last commit of Maglev is 4 years ago.

@hsbt hsbt merged commit 5038d9e into rbenv:master Dec 3, 2020
@metalefty metalefty deleted the maglev branch December 3, 2020 08:13
@mislav mislav mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants