Don't show Notify messages when more than 10 projects to load, include currently loading project in progress bar. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e currently loading project in progress bar.
|
LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading extremely large solutions, in my case, 600 projects (!!!), the entire neovim UI is just covered with notifications as it loads every project, over a period of several minutes.
Alternatively, this patch includes the name of the project file being loaded (just the specific csproj file name, not the whole relative path) in the progress updates.
(obviously, 10 may not be the ideal number to disable notifications for, thoughts on better ways to disable notification spam?)