feat: support different content types based on schema type #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4rikris
force-pushed
the
content-type-response
branch
from
06ce1bb
to
59051b1
Compare
pyadav
reviewed
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different schema types uses different data type to represent schemas. Avro and JSON schema types represented in JSON. Protobuf schema type transferred as byte stream. We chose
bytesdata type in gRPC to make it type agnostic. grpc-gateway uses standard protobuf to JSON mapping. As per the mapping rulesbytedata type represented as base64 string in json. While constructing HTTP calls clients have to encode/decode base64 data everytime which increases complexity on clients using HTTP API. This PR addresses to remove this extra encoding/decoding use original schema data types in http response.