Skip to content

Commit

Permalink
feat(stencil): remove http option for create/get schema data rpcs
Browse files Browse the repository at this point in the history
  • Loading branch information
h4rikris committed Dec 3, 2021
1 parent 628bfd6 commit c310a83
Showing 1 changed file with 9 additions and 31 deletions.
40 changes: 9 additions & 31 deletions odpf/stencil/v1beta1/stencil.proto
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,7 @@ service StencilService {
summary: "List schemas under the namespace";
};
}
rpc CreateSchema(CreateSchemaRequest) returns (CreateSchemaResponse) {
option (google.api.http) = {
post: "/v1beta1/namespaces/{namespace_id}/schemas/{schema_id}",
body: "*"
};
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
tags: "schema";
summary: "Create schema under the namespace. Returns version number, unique ID and location";
};
}
rpc CreateSchema(CreateSchemaRequest) returns (CreateSchemaResponse) {}
rpc GetSchemaMetadata(GetSchemaMetadataRequest) returns (GetSchemaMetadataResponse) {
option (google.api.http) = {
get: "/v1beta1/namespaces/{namespace_id}/schemas/{schema_id}/meta"
Expand All @@ -105,16 +96,7 @@ service StencilService {
summary: "Update only schema metadata";
};
}
rpc GetLatestSchema(GetLatestSchemaRequest) returns (GetLatestSchemaResponse) {
option (google.api.http) = {
get: "/v1beta1/namespaces/{namespace_id}/schemas/{schema_id}"
};
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
tags: "schema";
summary: "Get latest schema for specified schema id and namespace id";
description: "Returns schema data in byte64 format. Clients can decode 'data' field to expected data format"
};
}
rpc GetLatestSchema(GetLatestSchemaRequest) returns (GetLatestSchemaResponse) {}
rpc DeleteSchema(DeleteSchemaRequest) returns (DeleteSchemaResponse) {
option (google.api.http) = {
delete: "/v1beta1/namespaces/{namespace_id}/schemas/{schema_id}"
Expand All @@ -124,16 +106,7 @@ service StencilService {
summary: "Delete specified schema";
};
}
rpc GetSchema(GetSchemaRequest) returns (GetSchemaResponse) {
option (google.api.http) = {
get: "/v1beta1/namespaces/{namespace_id}/schemas/{schema_id}/versions/{version_id}"
};
option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
tags: "schema";
tags: "version";
summary: "Get schema for specified version";
};
}
rpc GetSchema(GetSchemaRequest) returns (GetSchemaResponse) {}
rpc ListVersions(ListVersionsRequest) returns (ListVersionsResponse) {
option (google.api.http) = {
get: "/v1beta1/namespaces/{namespace_id}/schemas/{schema_id}/versions"
Expand Down Expand Up @@ -173,7 +146,12 @@ message Schema {
}
enum Compatibility {
COMPATIBILITY_UNSPECIFIED = 0;
COMPATIBILITY_FULL = 1;
COMPATIBILITY_BACKWARD = 1;
COMPATIBILITY_BACKWARD_TRANSITIVE = 2;
COMPATIBILITY_FORWARD = 3;
COMPATIBILITY_FORWARD_TRANSITIVE = 4;
COMPATIBILITY_FULL = 5;
COMPATIBILITY_FULL_TRANSITIVE = 6;
}
string name = 1;
Format format = 2;
Expand Down

0 comments on commit c310a83

Please sign in to comment.