Skip to content

Commit

Permalink
Using SDK Version variables from root project
Browse files Browse the repository at this point in the history
Instead of assuming the `compileSdkVersion`, `targetSdkVersion`, etc, read it from the root project.
Default `compileSdkVersion` and `targetSdkVersion` to the latest versions.

Android Target API Level 26 will be required in August 2018.
https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html
And the React Native team is already working on this:
facebook/react-native#17741
facebook/react-native#18095
  • Loading branch information
rayronvictor committed Apr 24, 2018
1 parent e891ca9 commit bbdfd33
Showing 1 changed file with 18 additions and 9 deletions.
27 changes: 18 additions & 9 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,26 @@ buildscript {

apply plugin: 'com.android.library'

def _ext = rootProject.ext

def _reactNativeVersion = _ext.has('reactNative') ? _ext.reactNative : '+'
def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 27
def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '27.0.3'
def _minSdkVersion = _ext.has('minSdkVersion') ? _ext.minSdkVersion : 16
def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 27

android {
compileSdkVersion 23
buildToolsVersion "23.0.1"
compileSdkVersion _compileSdkVersion
buildToolsVersion _buildToolsVersion

defaultConfig {
minSdkVersion 16
targetSdkVersion 22
minSdkVersion _minSdkVersion
targetSdkVersion _targetSdkVersion
versionCode 1
versionName "1.0"
lintOptions {
abortOnError false
}
}
lintOptions {
abortOnError false
}
}

Expand All @@ -29,8 +37,9 @@ repositories {
}

dependencies {
compile 'com.facebook.react:react-native:+'
//noinspection GradleDynamicVersion
compile "com.facebook.react:react-native:${_reactNativeVersion}"
compile group: 'com.github.bumptech.glide', name: 'glide', version: '3.8.0'
compile group: 'com.github.bumptech.glide', name: 'okhttp3-integration', version: '1.5.0'
compile 'com.android.support:support-v4:19.1.0'
compile "com.android.support:support-v4:${_compileSdkVersion}.+"
}

0 comments on commit bbdfd33

Please sign in to comment.