fix an issue with the colored log in Windows shell. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Sorry for delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When running muffet with Windows PowerShell or Command prompt, the colored log portion does not display properly.
PowerShell on Windows 10 (1909)
Command prompt on Windows 10 (1909)
Solution
I fixed it by using go-colorable to replace
os.Stdout. Because this library returnsos.Stdoutasio.Writerfor non-Windows systems, I think that this fix have no effect on the operation of other OSes.fixed results
PowerShell on Windows 10 (1909)
Command prompt on Windows 10 (1909)
