Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muffet treats preconnect hrefs like links #391

Closed
movitz-s opened this issue Jun 24, 2024 · 3 comments · Fixed by #392
Closed

muffet treats preconnect hrefs like links #391

movitz-s opened this issue Jun 24, 2024 · 3 comments · Fixed by #392
Labels
bug Something isn't working

Comments

@movitz-s
Copy link
Contributor

Websites often have code like this

<link rel="preconnect" href="https://fonts.googleapis.com">

in order to increase performance. https://fonts.googleapis.com returns 404 but the HTML code is still valid and should not be checked by muffet.

Is this a unknown issue or am I doing something wrong with muffet?
I am willing to implement a fix for this, just lmk.

@raviqqe
Copy link
Owner

raviqqe commented Jun 24, 2024

You can exclude certain links with --exclude option. Can you try it?

@movitz-s
Copy link
Contributor Author

That is what I've done with the common font providers etc, but it is an imperfect solution since you might not know which domains are used in preconnect. It should be easy to fix for every preconnect link, I can implement it if wanted, as I said.

@raviqqe
Copy link
Owner

raviqqe commented Jun 26, 2024

I see. If you can implement it, I appreciate it!

@raviqqe raviqqe added the bug Something isn't working label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants