Update librmm conda recipe
#997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjacobelli
approved these changes
Mar 16, 2022
ajschmidt8
added
non-breaking
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
librmmcondarecipe with some learnings from rapidsai/cudf#10326.Namely that the top-level
build.shscript is the only feasible approach for consolidating the recipes.The implication of these changes is that any shared libraries used in the top-level build must now manually be specified as
rundependencies of the correspondingoutputspackage. To help reduce the amount of duplication of version specifications for these packages, dependency versions can be specified inconda/recipes/librmm/conda_build_config.yaml. The exception here is the version spec used forcudatoolkitsince that comes from an environment variable in the CI process.