Improve C++ Test Coverage #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
tests
robertmaynard
approved these changes
Nov 18, 2021
jrhemstad
reviewed
Nov 18, 2021
jrhemstad
reviewed
Nov 18, 2021
|
Now up to 99% coverage without whitebox testing (and explicit instantiations uncovered more untested code, which I've fixed). I have a couple more things to try to fix a few more uncovered functions. |
harrism
added
the
5 - Ready to Merge
|
Because a lot has been added since the reviewers approved, I'm rerequesting reviews. |
rongou
reviewed
Nov 29, 2021
Co-authored-by: Rong Ou <rong.ou@gmail.com>
rongou
approved these changes
Nov 30, 2021
jrhemstad
approved these changes
Nov 30, 2021
|
@gpucibot merge |
This was referenced Dec 3, 2021
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
Fixes #928. #920 introduced a new test for the `tracking_resource_adaptor::log_outstanding_allocations`, but that function only logs when `SPDLOG_ACTIVE_LEVEL <= SPDLOG_LEVEL_DEBUG`, so the test needs to be gated on that condition as well. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Rong Ou (https://github.com/rongou) - Vyas Ramasubramani (https://github.com/vyasr) - Bradley Dice (https://github.com/bdice) URL: #929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #905 added C++ code coverage support, this PR improves test coverage. Much of the improvement comes from adding a new
adaptor_test.cppwhich generically tests the common functions of all 7 adaptor types. Small test additions improve coverage of many other files as well. At least one typo bug was uncovered and fixed.If you build with
-DCODE_COVERAGE=ON -DRMM_LOGGING_LEVEL=TRACE, overall code coverage is now 99.5% and all but one file has 100% coverage. That one file, arena.hpp is undergoing work concurrent to this PR, and improvement to 100% requires additional testing that might be best undertaken by @rongou, so I will leave it.