Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cuda allocation alignment as default #917

Closed
wants to merge 3 commits into from

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Nov 12, 2021

This is a strict refactoring to make the calling code a bit simpler.

@rongou rongou added 3 - Ready for review Ready for review by team tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general non-breaking Non-breaking change improvement Improvement / enhancement to an existing function cpp Pertains to C++ code labels Nov 12, 2021
@rongou rongou self-assigned this Nov 12, 2021
@rongou rongou requested a review from a team as a code owner November 12, 2021 19:35
Copy link
Contributor

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #883 is complete, there will be nothing special about CUDA_ALLOCATION_ALIGNMENT vs any other specified alignment value that warrants defaulting it like this.

@rongou
Copy link
Contributor Author

rongou commented Nov 12, 2021

Hmm, but in #883 we are still calling (e.g. in binning_memory_resource):

allocation_size =
  rmm::detail::align_up(allocation_size, rmm::detail::CUDA_ALLOCATION_ALIGNMENT)

Don't we still need to do this type of alignments?

@jrhemstad
Copy link
Contributor

Hmm, but in #883 we are still calling (e.g. in binning_memory_resource):

allocation_size =
  rmm::detail::align_up(allocation_size, rmm::detail::CUDA_ALLOCATION_ALIGNMENT)

Don't we still need to do this type of alignments?

The new interface allows the user to specify the desired alignment. The default will be max_align_t, but that default is provided at the interface level, not internally in a function like this.

@rongou
Copy link
Contributor Author

rongou commented Nov 13, 2021

Wouldn't it still make sense to do this simple cleanup while we wait for the new interface?

@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@harrism
Copy link
Member

harrism commented Jan 11, 2022

Wouldn't it still make sense to do this simple cleanup while we wait for the new interface?

Possibly, given that #883 and cuda::memory_resource are dragging...

@harrism
Copy link
Member

harrism commented Jan 14, 2022

Moving to 22.04

@rongou rongou closed this Jan 21, 2022
@rongou rongou deleted the default-alignment branch January 21, 2022 17:50
@rongou rongou restored the default-alignment branch January 21, 2022 17:50
@rongou rongou reopened this Jan 21, 2022
@rongou rongou requested review from a team as code owners January 21, 2022 18:05
@github-actions github-actions bot added CMake Python Related to RMM Python API labels Jan 21, 2022
@rongou rongou changed the base branch from branch-22.02 to branch-22.04 January 21, 2022 18:05
@github-actions github-actions bot removed CMake Python Related to RMM Python API labels Jan 21, 2022
@rongou rongou removed request for a team January 21, 2022 22:39
@rongou
Copy link
Contributor Author

rongou commented Jan 26, 2022

rerun tests

@rongou
Copy link
Contributor Author

rongou commented Jan 26, 2022

@harrism should this be merged?

@harrism
Copy link
Member

harrism commented Jan 26, 2022

@jrhemstad needs to approve.

@jjacobelli
Copy link
Contributor

rerun tests

@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@rongou rongou closed this Mar 11, 2022
@rongou rongou deleted the default-alignment branch June 10, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team cpp Pertains to C++ code improvement Improvement / enhancement to an existing function inactive-30d non-breaking Non-breaking change tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants