Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading zeros in version_config.hpp #793

Merged

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jun 7, 2021

Since we switched to CalVer, the version strings contain leading zeros, e.g. 21.08.00. This leads to the generated header version_config.hpp to contain

#define RMM_VERSION_MAJOR 21
#define RMM_VERSION_MINOR 08
#define RMM_VERSION_PATCH 00

in which 08 is an invalid octal literal. See the resulting CI failure at https://gpuci.gpuopenanalytics.com/job/rapidsai/job/conda/job/xgboost/job/xgboost-conda-build/229/CUDA=11.0,PYTHON=3.7/console. The generated header is used by XGBoost.

Fix: Remove the leading zeros in the C++ constants so that we'd get

```cpp
#define RMM_VERSION_MAJOR 21
#define RMM_VERSION_MINOR 8
#define RMM_VERSION_PATCH 0

@hcho3 hcho3 requested a review from a team as a code owner June 7, 2021 19:07
@github-actions github-actions bot added the CMake label Jun 7, 2021
@ajschmidt8 ajschmidt8 added bug Something isn't working non-breaking Non-breaking change labels Jun 7, 2021
@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e2832e3 into rapidsai:branch-21.08 Jun 7, 2021
@hcho3 hcho3 deleted the remove_leading_zero_in_version branch June 7, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants