Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple output sinks in logging_resource_adaptor #791

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Support multiple output sinks in logging_resource_adaptor #791

merged 1 commit into from
Jun 2, 2021

Conversation

harrism
Copy link
Member

@harrism harrism commented Jun 1, 2021 •
edited
Loading

Adds a constructor to rmm::mr::logging_resource_adaptor that takes an init list of spdlog sinks. This enables creation of multiple sinks so that a logging_resource_adaptor may output to multiple places (For example to a file and an output stream). Also adds a test.

Closes #679

@harrism harrism requested a review from a team as a code owner June 1, 2021 03:14
@harrism harrism requested review from rongou and codereport June 1, 2021 03:14
@github-actions github-actions bot added the cpp Pertains to C++ code label Jun 1, 2021
@harrism harrism added feature request New feature or request non-breaking Non-breaking change and removed cpp Pertains to C++ code labels Jun 1, 2021
@harrism harrism self-assigned this Jun 1, 2021
codereport
codereport approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@harrism
Copy link
Member Author

harrism commented Jun 2, 2021

rerun tests

@harrism harrism added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 2, 2021
@harrism
Copy link
Member Author

harrism commented Jun 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 21e3002 into rapidsai:branch-21.08 Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

@codereport codereport codereport approved these changes

Assignees

@harrism harrism

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Enable multiple sinks in logging_resource_adaptor
3 participants
@harrism @rongou @codereport