Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document synchronization requirements on device_buffer copy ctors #772

Merged

Conversation

harrism
Copy link
Member

@harrism harrism commented May 11, 2021

Document caller synchronization expectations for copy constructors of device_buffer.

Fixes #766

@harrism harrism requested a review from a team as a code owner May 11, 2021 23:43
@harrism harrism requested review from rongou and codereport May 11, 2021 23:43
@github-actions github-actions bot added the cpp Pertains to C++ code label May 11, 2021
@harrism harrism requested a review from jlowe May 11, 2021 23:43
@harrism harrism self-assigned this May 11, 2021
@harrism harrism added doc Documentation non-breaking Non-breaking change labels May 11, 2021
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codereport
Copy link
Contributor

@gpucibot merge

@harrism
Copy link
Member Author

harrism commented May 17, 2021

rerun tests

@harrism harrism changed the title Document synchronization requirements on device_buffer copy ctors Document synchronization requirements on device_buffer copy ctors [] May 18, 2021
@rapids-bot rapids-bot bot merged commit 19a745e into rapidsai:branch-21.06 May 18, 2021
@harrism harrism changed the title Document synchronization requirements on device_buffer copy ctors [] Document synchronization requirements on device_buffer copy ctors May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Pertains to C++ code doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] device_buffer constructor with initial data does not mention required synchronization
4 participants