[REVIEW] Fix cython tests #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @shwina to review |
jakirkham
added
3 - Ready for review
shwina
reviewed
Apr 7, 2021
kkraus14
approved these changes
Apr 7, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #739, we have removed
__init__.pyfromtestsdirectory. We were having this to be able to importtest_device_bufferwhich was intestsdirectory, but in some environments, we consistently run into this following issue: https://stackoverflow.com/a/41752043, so we have to treattestsas a directory only and not as a module. With this change on some setups, eithertest_rmm.pysilently gets skipped or errors with following error in CI:https://gpuci.gpuopenanalytics.com/view/RAPIDS%20-%20Pascal%20Tests/job/rapidsai/job/gpuci/job/rmm/job/branches/job/rmm-gpu-pascal-branch-0.19/CUDA=10.1/33/console
As part of this PR, we are moving all the cython files required to test under an internal
rmm._test_cythonmodule and this way we should be able to pytest thetest_cython.py.