Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device_uvector can be used within thrust::optional #734

Merged
merged 1 commit into from
Mar 18, 2021
Merged

device_uvector can be used within thrust::optional #734

merged 1 commit into from
Mar 18, 2021

Conversation

robertmaynard
Copy link
Contributor

Fixes rapidsai/cudf#7629

Since thrust::optional is marked with host and device markup,
we need to make sure we don't generate errors when device_uvector
is placed inside of it as it will inherit the device markup.

@robertmaynard robertmaynard requested a review from a team as a code owner March 18, 2021 01:08
@github-actions github-actions bot added the cpp Pertains to C++ code label Mar 18, 2021
jrhemstad
jrhemstad reviewed Mar 18, 2021
View reviewed changes
Copy link
Contributor

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might throw a warning in host only code about unrecognized pragma? Probably better to wrap it in a macro behind an ifdef __CUDACC__

@robertmaynard robertmaynard force-pushed the fix/device_uvector_and_thrust_optional branch from 423ec3d to 94bb873 Compare March 18, 2021 14:32
@robertmaynard robertmaynard requested a review from a team as a code owner March 18, 2021 14:32
@github-actions github-actions bot added the conda label Mar 18, 2021
@robertmaynard
device_uvector can be used within thrust::optional
94ae870 
Fixes rapidsai/cudf#7629

Since thrust::optional is marked with host and device markup,
we need to make sure we don't generate errors when device_uvector
is placed inside of it as it will inherit the device markup.
@robertmaynard robertmaynard force-pushed the fix/device_uvector_and_thrust_optional branch from 94bb873 to 94ae870 Compare March 18, 2021 15:33
@jrhemstad jrhemstad added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 18, 2021
@jrhemstad
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dc3ca44 into rapidsai:branch-0.19 Mar 18, 2021
@robertmaynard robertmaynard mentioned this pull request Mar 18, 2021
Closed
@robertmaynard robertmaynard deleted the fix/device_uvector_and_thrust_optional branch March 18, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@codereport codereport Awaiting requested review from codereport

Assignees
No one assigned
Labels
conda cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Compilation fails with device_uvector destructor error
4 participants
@robertmaynard @jrhemstad @rongou @ajschmidt8