Fix auto-detecting GPU architectures #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkraus14
approved these changes
Mar 14, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2021
Follow up to #727 after discussing with @robertmaynard it was decided that setting `CMAKE_CUDA_ARCHITECTURES` to `OFF` instead of undefined is better. Authors: - Paul Taylor (@trxcllnt) Approvers: - Keith Kraus (@kkraus14) URL: #729
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Mar 15, 2021
Fixes regression from #7579 in auto-detecting GPU architectures when `-DCMAKE_CUDA_ARCHITECTURES=` is passed on the CLI. Now that the cached `CMAKE_CUDA_ARCHITECTURES` isn't unset before calling `enable_language(CUDA)`, this call throws an error and configuration fails. This change ensures we call `enable_language(CUDA)` after any potential rewrites of `CMAKE_CUDA_ARCHITECTURES`. This PR also aligns with RMM's `EvalGPUArchs.cmake` logic and prints `SUPPORTED_CUDA_ARCHITECTURES` instead of `"ALL"` in the case the current machine is a CPU-only node. Related: rapidsai/rmm#727 Authors: - Paul Taylor (@trxcllnt) - Robert Maynard (@robertmaynard) Approvers: - Keith Kraus (@kkraus14) URL: #7593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from #726 in auto-detecting GPU architectures when
-DCMAKE_CUDA_ARCHITECTURES=is passed on the CLI.Now that the cached
CMAKE_CUDA_ARCHITECTURESisn't unset before callingenable_language(CUDA), this call throws an error and configuration fails. This change ensures we callenable_language(CUDA)after any potential rewrites ofCMAKE_CUDA_ARCHITECTURES.