Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Simplify cmake cuda architectures handling #709

Conversation

robertmaynard
Copy link
Contributor

Based on #706 as they both modify cmake/Modules/SetGPUArchs.cmake

This brings rmm's handling of CMAKE_CUDA_ARCHITECTURES to match that is proposed for cudf in rapidsai/cudf#7391

@robertmaynard robertmaynard requested a review from a team as a code owner February 17, 2021 19:31
@github-actions github-actions bot added CMake cpp Pertains to C++ code labels Feb 17, 2021
@kkraus14 kkraus14 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2021
@rapidsai rapidsai deleted a comment from akagamy55 Feb 18, 2021
@rapidsai rapidsai deleted a comment from akagamy55 Feb 18, 2021
@rapidsai rapidsai deleted a comment from akagamy55 Feb 18, 2021
@rapidsai rapidsai deleted a comment from akagamy55 Feb 18, 2021
@robertmaynard robertmaynard force-pushed the simplify_CMAKE_CUDA_ARCHITECTURES_handling branch 3 times, most recently from 349e691 to 7199396 Compare February 18, 2021 21:15
@robertmaynard robertmaynard changed the title [WIP] Simplify cmake cuda architectures handling [REVIEW] Simplify cmake cuda architectures handling Feb 19, 2021
Improve how we handle CUDA arch settings by moving
some of the logic into the root CMakeLists. This
will allow us to specify CUDA as a language in our project()
call once we require CMake 3.20.
@robertmaynard robertmaynard force-pushed the simplify_CMAKE_CUDA_ARCHITECTURES_handling branch from 7199396 to fa1773b Compare February 23, 2021 22:13
@github-actions github-actions bot removed the cpp Pertains to C++ code label Feb 23, 2021
@robertmaynard robertmaynard force-pushed the simplify_CMAKE_CUDA_ARCHITECTURES_handling branch from fa1773b to 08a1aae Compare February 24, 2021 14:23
@kkraus14
Copy link
Contributor

@robertmaynard any more changes before we merge this? Thanks!

@robertmaynard
Copy link
Contributor Author

robertmaynard commented Feb 24, 2021 via email

@kkraus14
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dc5889b into rapidsai:branch-0.19 Feb 24, 2021
@robertmaynard robertmaynard deleted the simplify_CMAKE_CUDA_ARCHITECTURES_handling branch February 26, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants