Deprecate support for directly accessing logger #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
breaking
wence-
reviewed
Oct 1, 2024
| [[deprecated( | ||
| "Support for direct access to spdlog loggers in rmm is planned for " | ||
| "removal")]] RMM_EXPORT inline spdlog::logger& | ||
| logger() |
There was a problem hiding this comment.
Note this makes all the RMM_LOG_XXX macros produce warnings, I think.
There was a problem hiding this comment.
Good point. I can add a level of indirection to help with this.
bdice
approved these changes
Oct 1, 2024
wence-
approved these changes
Oct 2, 2024
|
Setting to do not merge, I think the Cython bindings in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#104
This PR removes support for accessing rmm's underlying spdlog logger directly.
Checklist