Attempt to address oom failures in test suite #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audit the existing MR tests and serialize those that make large allocations (specifically, a pool with 90% of the available device memory). This also allows us to remove serialization from some of the tests which don't make large allocations.
wence-
added
non-breaking
bdice
approved these changes
Sep 6, 2024
| @@ -125,7 +125,7 @@ ConfigureTest(DEVICE_MR_REF_TEST mr/device/mr_ref_tests.cpp | |||
| ConfigureTest(ADAPTOR_TEST mr/device/adaptor_tests.cpp) | |||
|
|
|||
| # pool mr tests | |||
| ConfigureTest(POOL_MR_TEST mr/device/pool_mr_tests.cpp GPUS 1 PERCENT 60) | |||
| ConfigureTest(POOL_MR_TEST mr/device/pool_mr_tests.cpp GPUS 1 PERCENT 100) | |||
There was a problem hiding this comment.
Note: Large allocation occurs here:
rmm/tests/mr/device/pool_mr_tests.cpp
Line 74 in 9864b51
| @@ -182,7 +182,7 @@ ConfigureTest(PREFETCH_TEST prefetch_tests.cpp) | |||
| ConfigureTest(LOGGER_TEST logger_tests.cpp) | |||
|
|
|||
| # arena MR tests | |||
| ConfigureTest(ARENA_MR_TEST mr/device/arena_mr_tests.cpp GPUS 1 PERCENT 60) | |||
| ConfigureTest(ARENA_MR_TEST mr/device/arena_mr_tests.cpp GPUS 1 PERCENT 100) | |||
There was a problem hiding this comment.
Note: Large allocation occurs here:
rmm/tests/mr/device/arena_mr_tests.cpp
Lines 487 to 495 in 9864b51
We should refactor this test to use rmm::percent_of_free_device_memory. I think the only difference is whether it uses rmm::align_up vs. rmm::align_down, but that seems unimportant here?
There was a problem hiding this comment.
I'll do this one separately.
|
Thanks @wence- ! |
harrism
approved these changes
Sep 6, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Audit the existing MR tests and serialize those that make large allocations (specifically, a pool with 90% of the available device memory). This also allows us to remove serialization from some of the tests which don't make large allocations.
Checklist