Propagate exceptions raised in Python callback functions #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
force-pushed
the
callback_mr_handle_exception
branch
from
cc86be3
to
7e8705e
Compare
shwina
reviewed
Sep 22, 2022
bdice
reviewed
Sep 22, 2022
shwina
approved these changes
Sep 23, 2022
|
@bdice anything else needed here? |
vyasr
reviewed
Sep 26, 2022
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
vyasr
approved these changes
Sep 27, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we ignore Python exceptions raised in callback functions called by resources such as
CallbackMemoryResource. This is because Cython doesn't automatically translate Python exceptions into C++ exceptions (even though Cython does translate C++ exceptions into Python automatically).To address this issue, we now translate Python exceptions raised in the callback function into a C++ exception manually. Next, we remove Cython's automatic C++ to Python exception translation by not using the
except +declaration. Thus, when the callback raises an exception, the caller (a memory resource implemented in C++) can catch and/or propagate the exception.Checklist