Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cuda::mr::memory_resource instead of raw device_memory_resource #1095

Merged
merged 37 commits into from
Nov 17, 2023
Merged

Use cuda::mr::memory_resource instead of raw device_memory_resource #1095

merged 37 commits into from
Nov 17, 2023

Commits on Oct 17, 2023

  1. Add cccl repo to build dependencies

    @miscco
    miscco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    90adef2 View commit details
    Browse the repository at this point in the history

  2. PoC for the new design of cuda::mr::{async_}resource_ref

    @miscco
    miscco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a49fe9c View commit details
    Browse the repository at this point in the history

  3. Make pinned_memory_resource usable for pool_memory_resource

    @miscco
    miscco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    0e78d9e View commit details
    Browse the repository at this point in the history

  4. Port device_buffer and device_uvector to the new interface

    @miscco
    miscco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4d25841 View commit details
    Browse the repository at this point in the history

  5. Add cccl repo to build dependencies

    @miscco
    miscco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    de71dcc View commit details
    Browse the repository at this point in the history

  6. PoC for the new design of cuda::mr::{async_}resource_ref

    @miscco
    miscco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    13a990f View commit details
    Browse the repository at this point in the history

  7. Make pinned_memory_resource usable for pool_memory_resource

    @miscco
    miscco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9ceab83 View commit details
    Browse the repository at this point in the history

  8. Port device_buffer and device_uvector to the new interface

    @miscco
    miscco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c0df290 View commit details
    Browse the repository at this point in the history

  9. Use upstream patch for memory resource.

    @bdice
    bdice committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    8b1bc04 View commit details
    Browse the repository at this point in the history

  10. Add target_link_libraries for libcudacxx.

    @bdice
    bdice committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    bccabd1 View commit details
    Browse the repository at this point in the history

  11. Revert "Use upstream patch for memory resource." 

    This reverts commit 8b1bc04.
    @bdice
    bdice committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    5b27e10 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge branch 'memory_resource' of github.com:miscco/rmm into memory_r… 

    …esource
    @miscco
    miscco committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    194da78 View commit details
    Browse the repository at this point in the history

  2. Add restrictions on memory usage for tests

    @miscco
    miscco committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    6e610a3 View commit details
    Browse the repository at this point in the history

  3. Remove get_current_device_resource_ref 

    It is not really usefull as we are constrained to only using `device_accessible` and we can easily construct any resource_ref from it anyway
    @miscco
    miscco committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    edb8f78 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Make CI happy

    @miscco
    miscco committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4ea703e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge branch 'branch-23.12' into memory_resource

    @harrism
    harrism authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    e9a5ace View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Merge branch 'branch-23.12' into memory_resource

    @miscco
    miscco committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    df9c6e9 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @miscco
    miscco committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8e7c91b View commit details
    Browse the repository at this point in the history

  3. Address alignment differences with cuda::mr::resource_ref 

    Our implementation of `cuda::mr::{async_}resource_ref` currently aligns to `alignof(max_align_t)`

This is a minor difference to the current device_memory_resource. We intent to expand the interface of `cuda::mr::{async_}resource_ref` to take desired alignment into account.

However, this is out of scope of this PR and will be done in the cccl repository
    @miscco
    miscco committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    849c880 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Roll back the changes to device_u{buffer, vector} 

    Those are potentially breaking and we want to do that in a followup
    @miscco
    miscco committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    2cf03a7 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @miscco
    miscco committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    76d55fa View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Revert "Roll back the changes to device_u{buffer, vector}" 

    This reverts commit 2cf03a7.
    @miscco
    miscco committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    3390fb8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-23.12' into memory_resource

    @miscco
    miscco committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c0c8504 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Add a check that we do not store unnecessary data inside a `async_res… 

    …ource_ref `

While we are at it also properly test that a `device_memory_resource` is a `async_resource`
    @miscco
    miscco committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    559a674 View commit details
    Browse the repository at this point in the history

  2. Properly test that a device_memory_resource is an async_resource

    @miscco
    miscco committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c1f36d8 View commit details
    Browse the repository at this point in the history

  3. Also port rmm::mr::thrust_allocator to async_resource_ref`

    @miscco
    miscco committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    1d422b5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-23.12' into memory_resource

    @miscco
    miscco committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    17021f1 View commit details
    Browse the repository at this point in the history

  5. Do not put rmm::bad_alloc in quotes 

    Also `Nothing` seems to be an invalid type
    @miscco
    miscco committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e867442 View commit details
    Browse the repository at this point in the history

  6. Try to avoid namespaces in comments

    @miscco
    miscco committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    73efc2e View commit details
    Browse the repository at this point in the history

  7. Tell sphinx to skipp documenting libcu++ names

    @miscco
    miscco committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c298fbc View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Merge branch 'branch-23.12' into memory_resource

    @harrism
    harrism authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    41c1bea View commit details
    Browse the repository at this point in the history

  2. Update copyright years.

    @bdice
    bdice committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    80201bd View commit details
    Browse the repository at this point in the history

  3. Fix typos and grammar.

    @bdice
    bdice committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    5937e3e View commit details
    Browse the repository at this point in the history

  4. Drop support for CUDA older than CUDA 11 in tests.

    @bdice
    bdice committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    baf99f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Do not propagate the device_accessible property for containers 

    We currently have no design on how we want to propagate the properties of the memory_resource, so drop this for now until have a proper design ready
    @miscco
    miscco committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    af12733 View commit details
    Browse the repository at this point in the history

  2. Fix deadlock in new tests using fix from rapidsai#1097

    @harrism
    harrism committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    37c1e3f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'memory_resource' of https://github.com/miscco/rmm into … 

    …memory_resource
    @harrism
    harrism committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    67d1bdc View commit details
    Browse the repository at this point in the history