Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unused parameter warnings in do_get_mem_info #1084

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Avoid unused parameter warnings in do_get_mem_info #1084

merged 5 commits into from
Sep 28, 2022

Conversation

fkallen
Copy link
Contributor

@fkallen fkallen commented Aug 9, 2022

closes #1032

@fkallen fkallen requested a review from a team as a code owner August 9, 2022 07:48
@fkallen fkallen requested review from rongou and vyasr August 9, 2022 07:48
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions github-actions bot added the cpp Pertains to C++ code label Aug 9, 2022
@harrism harrism added bug Something isn't working non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed improvement Improvement / enhancement to an existing function labels Aug 9, 2022
@harrism harrism removed the request for review from rongou August 10, 2022 01:25
@rongou
Copy link
Contributor

rongou commented Aug 15, 2022

ok to test

@harrism
Copy link
Member

harrism commented Aug 15, 2022

ok to test

@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@harrism
Copy link
Member

harrism commented Sep 19, 2022

@fkallen can you run clang-format to fix the style failures?

@harrism
Copy link
Member

harrism commented Sep 20, 2022

Hmmm, that doesn't seem to have fixed it.

@harrism
Copy link
Member

harrism commented Sep 28, 2022

@gpucibot merge

@harrism
Copy link
Member

harrism commented Sep 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d8c18e6 into rapidsai:branch-22.10 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

@harrism harrism harrism approved these changes

@jrhemstad jrhemstad jrhemstad approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees
No one assigned
Labels
bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unused parameter warnings for do_get_mem_info
6 participants
@fkallen @GPUtester @rongou @harrism @jrhemstad @ajschmidt8