Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build.sh to find C++ library by default and avoid shadowing CMAKE_ARGS #1053

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 31, 2022

Discussions with the team indicated a general preference for having build.sh default to finding the C++ library by default (and erroring if one is not found) rather than building a new copy of librmm when building rmm Python. This change has little effect on rmm since it's header-only, but is being made for consistency with other libraries. More importantly, this PR also avoids shadowing the CMAKE_ARGS environment variable in build.sh, which is important for conda-forge compatibility.

@vyasr vyasr self-assigned this May 31, 2022
@vyasr vyasr added 3 - Ready for review Ready for review by team CMake non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 31, 2022
@vyasr vyasr removed the CMake label May 31, 2022
@vyasr vyasr added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for review Ready for review by team labels Jun 1, 2022
@vyasr vyasr changed the title Change build.sh to find C++ library by default. Change build.sh to find C++ library by default and avoid shadowing CMAKE_ARGS Jun 3, 2022
@vyasr vyasr added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Jun 3, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Jun 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 270b35b into rapidsai:branch-22.08 Jun 3, 2022
@vyasr vyasr deleted the fix/build_sh_cpp_finding branch June 3, 2022 18:42
@vyasr vyasr mentioned this pull request Jun 4, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants