Clarifies Python requirements and version constraints #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with other version constraints on `cuda-python` already included here.
This is consistent with RAPIDS own NumPy version constraint.
This is consitent with other version constraints on `numba` in this repo so use it `install_requires` too.
|
@jakirkham we just started burn down, so please target 22.08 with this change. |
|
Just trying to tidy up the package requirements so they are correct in the release packages. |
bdice
approved these changes
May 19, 2022
|
The risk/benefit for 22.06 vs. 22.08 strikes me as being worth making this change in 22.06 to ensure the released packages have the proper requirements specified. This PR seems more likely to solve problems than to create them, based on the issues (captured in offline discussions) that led to #945. |
ajschmidt8
approved these changes
May 19, 2022
vyasr
approved these changes
May 20, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #945
Python requirements were a bit fuzzy or inconsistent in places. This straightens them out and applies the same constraint in various places.