Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] std::thread is used without #include <thread> #937

Closed
kkraus14 opened this issue Dec 22, 2021 · 0 comments · Fixed by #938
Closed

[BUG] std::thread is used without #include <thread> #937

kkraus14 opened this issue Dec 22, 2021 · 0 comments · Fixed by #938
Assignees
@robertmaynard
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@kkraus14
Copy link
Contributor

Describe the bug
std::thread is used in the arena memory resource without including the appropriate header: https://github.com/rapidsai/rmm/blob/branch-22.02/include/rmm/mr/device/arena_memory_resource.hpp#L301

Also used in the tests here: https://github.com/rapidsai/rmm/blob/branch-22.02/tests/mr/device/arena_mr_tests.cpp#L62. It doesn't trigger on this test build likely due to a transitive include somewhere.

Environment details (please complete the following information):
I'm using the conda shipped compilers along with CUDA / nvcc 11.4.
@kkraus14 kkraus14 added ? - Needs Triage Need team to review and classify bug Something isn't working labels Dec 22, 2021
robertmaynard added a commit to robertmaynard/rmm that referenced this issue Jan 5, 2022
@robertmaynard
Headers that use std::thread now include <thread>
febd7f0 
Fixes rapidsai#937
@robertmaynard robertmaynard self-assigned this Jan 5, 2022
@robertmaynard robertmaynard mentioned this issue Jan 5, 2022
Merged
@rapids-bot rapids-bot bot closed this as completed in #938 Jan 5, 2022
rapids-bot bot pushed a commit that referenced this issue Jan 5, 2022
@robertmaynard
Headers that use std::thread now include <thread> (#938)
8c5ed6a 
Fixes #937

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Keith Kraus (https://github.com/kkraus14)
  - Jake Hemstad (https://github.com/jrhemstad)
  - Conor Hoekstra (https://github.com/codereport)
  - Rong Ou (https://github.com/rongou)

URL: #938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertmaynard robertmaynard

Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Headers that use std::thread now include <thread> robertmaynard/rmm
2 participants
@robertmaynard @kkraus14